Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for XFS filesystem #253

Merged
merged 1 commit into from Mar 26, 2019
Merged

Add support for XFS filesystem #253

merged 1 commit into from Mar 26, 2019

Conversation

leakingtapan
Copy link
Contributor

@leakingtapan leakingtapan commented Mar 24, 2019 •
edited

Is this a bug fix or adding new feature?
Fixes: #194

  • Add example for storageclass using xfs
  • Update Dockerfile to install mkfs.xfs

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 24, 2019
@coveralls
Copy link

coveralls commented Mar 24, 2019 •
edited

Pull Request Test Coverage Report for Build 558

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.689%
Totals Coverage Status
Change from base Build 556: 0.0%
Covered Lines: 997
Relevant Lines: 1495
💛 - Coveralls

@leakingtapan
Copy link
Contributor Author

/cc @bertinatto

@leakingtapan
Copy link
Contributor Author

/retest

Add support for XFS filesystem
f267131 
* Add integration test
* Update README with storageclass example
@leakingtapan leakingtapan merged commit f4ab0ba into kubernetes-sigs:master Mar 26, 2019
@leakingtapan leakingtapan deleted the xfs branch March 26, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-nishi d-nishi Awaiting requested review from d-nishi

@ddebroy ddebroy Awaiting requested review from ddebroy

@bertinatto bertinatto Awaiting requested review from bertinatto

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for XFS file system type
3 participants
@leakingtapan @k8s-ci-robot @coveralls