Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor controller unit test with proper mock #269
Is this a bug fix or adding new feature?
What is this PR about? / Why do we need it?
What testing is done?
Hi @zacharya. Thanks for your PR.
I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
Pull Request Test Coverage Report for Build 593
referenced this pull request
Apr 5, 2019
@leakingtapan I think I've touched on all of your suggestions. I went through each test case with the goal of making each more readable (rather than bring the dynamic error handling logic over from the previous state). Let me know if you see anything that still needs fixing.
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing