Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use kubernetes 1.15 as dependency #345

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@leakingtapan
Copy link
Contributor

commented Aug 15, 2019

Is this a bug fix or adding new feature?
Since k8s 1.15+ uses go mod for vendering dependencies, it causes problem for dependencies using replace directive.

Add update-gomod.sh to update go.mod when consuming k/k as go module

Ref: kubernetes/kubernetes#79384

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from d-nishi and ddebroy Aug 15, 2019
@k8s-ci-robot k8s-ci-robot added the size/L label Aug 15, 2019
@coveralls

This comment has been minimized.

Copy link

commented Aug 15, 2019

Pull Request Test Coverage Report for Build 755

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.1%

Totals Coverage Status
Change from base Build 751: 0.0%
Covered Lines: 1176
Relevant Lines: 1654

💛 - Coveralls
Add update-gomod.sh for updating go.mod
@leakingtapan leakingtapan force-pushed the leakingtapan:k8s branch from 76833a3 to f9ddc17 Aug 15, 2019
@k8s-ci-robot k8s-ci-robot added size/XL and removed size/L labels Aug 15, 2019
@leakingtapan leakingtapan referenced this pull request Aug 15, 2019
@wongma7

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

Nice! TBH I kind of hate that we have to do this, I almost want to stay with dep, but dep is super slow. Anyway it's k/k's fault. Will go mod commands like tidy and vendor still work?

@wongma7

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

/lgtm

@leakingtapan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

Will go mod commands like tidy and vendor still work?

go mod vendor still works that's how I get to test this change locally. go mod tidy seems to still works. But I haven't tested it enough

@wongma7

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit debfdb4 into kubernetes-sigs:master Aug 15, 2019
10 checks passed
10 checks passed
cla/linuxfoundation leakingtapan authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 71.1%
Details
pull-aws-ebs-csi-driver-e2e-multi-az Job succeeded.
Details
pull-aws-ebs-csi-driver-e2e-single-az Job succeeded.
Details
pull-aws-ebs-csi-driver-integration Job succeeded.
Details
pull-aws-ebs-csi-driver-sanity Job succeeded.
Details
pull-aws-ebs-csi-driver-unit Job succeeded.
Details
pull-aws-ebs-csi-driver-verify Job succeeded.
Details
tide In merge pool.
Details
@leakingtapan leakingtapan deleted the leakingtapan:k8s branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.