Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up deploy manifest for 1.14 #51

Merged
merged 2 commits into from Jul 24, 2019

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Jul 18, 2019

Is this a bug fix or adding new feature?
bug fix+feature
What is this PR about? / Why do we need it?

What testing is done?
The static_provisioning example works correctly on a 1.14/1.15 cluster.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2019
@wongma7 wongma7 force-pushed the apps-manifest branch 2 times, most recently from a99b668 to 86d76f8 Compare July 18, 2019 19:50
@wongma7 wongma7 changed the title Migrate manifests from deprecated apps/* to apps/v1 Clean up deploy manifest for 1.14 Jul 18, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2019
volumes:
- name: socket-dir
emptyDir: {}
attachRequired: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you added skip-attach to the driver, could you add this to What is this PR about? / Why do we need it? of the PR description as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, updated description to mention skip attach explicitly

@leakingtapan
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit ee468e4 into kubernetes-sigs:master Jul 24, 2019
@leakingtapan
Copy link
Contributor

Because of skip attach relies on CSIDriver object, we need to highlight that this is backward incompatible change for 0.1 release (which is compatible with 1.13)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to latest node-driver-registrar Use skip attach
3 participants