Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests #103

Merged
merged 2 commits into from Oct 11, 2019
Merged

Add e2e tests #103

merged 2 commits into from Oct 11, 2019

Conversation

@leakingtapan
Copy link
Contributor

leakingtapan commented Oct 8, 2019

Is this a bug fix or adding new feature?
Add e2e tests:

  • Add e2e tests skeleton
  • Implement tests

Fixes: #49

@k8s-ci-robot k8s-ci-robot requested review from d-nishi and jsafrane Oct 8, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leakingtapan leakingtapan force-pushed the leakingtapan:e2e branch 2 times, most recently from b195b7b to f3752e4 Oct 8, 2019
@k8s-ci-robot k8s-ci-robot added size/XL and removed size/L labels Oct 10, 2019
@leakingtapan leakingtapan force-pushed the leakingtapan:e2e branch from f3752e4 to 475d110 Oct 10, 2019
Add tests
@leakingtapan leakingtapan force-pushed the leakingtapan:e2e branch 2 times, most recently from 7758602 to 3af8085 Oct 10, 2019
@k8s-ci-robot k8s-ci-robot added size/XXL and removed size/XL labels Oct 11, 2019
@leakingtapan leakingtapan force-pushed the leakingtapan:e2e branch 2 times, most recently from da5f142 to 8649833 Oct 11, 2019
@leakingtapan leakingtapan force-pushed the leakingtapan:e2e branch from 8649833 to a64379e Oct 11, 2019
@leakingtapan

This comment has been minimized.

Copy link
Contributor Author

leakingtapan commented Oct 11, 2019

/cc @wongma7

@k8s-ci-robot k8s-ci-robot requested a review from wongma7 Oct 11, 2019
@wongma7

This comment has been minimized.

Copy link
Contributor

wongma7 commented Oct 11, 2019

/lgtm
nice!

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 23e3eb0 into kubernetes-sigs:master Oct 11, 2019
6 of 7 checks passed
6 of 7 checks passed
tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation leakingtapan authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 50.744%
Details
pull-aws-fsx-csi-driver-e2e Job succeeded.
Details
pull-aws-fsx-csi-driver-unit Job succeeded.
Details
pull-aws-fsx-csi-driver-verify Job succeeded.
Details
@leakingtapan leakingtapan deleted the leakingtapan:e2e branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.