Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI driver support on Windows #45

Closed
andyzhangx opened this issue Feb 20, 2019 · 12 comments · Fixed by #247
Closed

CSI driver support on Windows #45

andyzhangx opened this issue Feb 20, 2019 · 12 comments · Fixed by #247
Assignees
@kkmsft
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@andyzhangx
Copy link
Member

andyzhangx commented Feb 20, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.

Currently CSI driver is linux based, cannot run on Windows. The main difficulty is design difference between Linux and Windows, all devices are files while it's not true for Windows.
Here is a issue link in moby talking about this issue: moby/moby#38479

Describe the solution you'd like in detail

We could make the attacher and azure disk csi driver running as a standalone process on Windows, that could work. (could refer to kube-proxy and kubelet implementation in aks-engine: https://github.com/Azure/aks-engine/blob/master/parts/k8s/kuberneteswindowssetup.ps1#L129-L130)
For the provision part, it could still run on Linux(on master node?). That would make it a little easier to implement.

Describe alternatives you've considered

Additional context

https://github.com/kubernetes/enhancements/blob/master/keps/sig-windows/20190714-windows-csi-support.md

node-driver-registrar support on Windows
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 21, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 20, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx andyzhangx reopened this Jul 20, 2019
@andyzhangx
Copy link
Member Author

you could refer to https://github.com/kubernetes/enhancements/blob/master/keps/sig-windows/20190714-windows-csi-support.md
/assign @kkmsft

@k8s-ci-robot
Copy link
Contributor

@andyzhangx: GitHub didn't allow me to assign the following users: kkmsft.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

you could refer to https://github.com/kubernetes/enhancements/blob/master/keps/sig-windows/20190714-windows-csi-support.md
/assign @kkmsft

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feiskyer feiskyer mentioned this issue Sep 3, 2019
Closed
@feiskyer
Copy link
Member

feiskyer commented Sep 6, 2019

/cc @ritazh for Windows CSI support

@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx andyzhangx reopened this Oct 6, 2019
@kkmsft
Copy link
Contributor

kkmsft commented Oct 15, 2019 •
edited
Loading

/cc @kkmsft

@feiskyer feiskyer removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Nov 13, 2019
@andyzhangx andyzhangx added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 27, 2019
@andyzhangx andyzhangx changed the title [feature] make azure disk CSI driver work on Windows CSI driver support on Windows Dec 13, 2019
@andyzhangx andyzhangx added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Dec 13, 2019
@kkmsft
Copy link
Contributor

kkmsft commented Dec 13, 2019

/assign @kkmsft

@kkmsft kkmsft mentioned this issue Jan 6, 2020
Merged
@andyzhangx
Copy link
Member Author

reopen since PR #247 is only part of this work

@andyzhangx andyzhangx reopened this Feb 28, 2020
@ZeroMagic ZeroMagic mentioned this issue Mar 23, 2020
Merged
@y2kdread y2kdread mentioned this issue Apr 6, 2021
Closed
sunpa93 pushed a commit to sunpa93/azuredisk-csi-driver that referenced this issue May 7, 2021
@mukhoakash
TestCreateVolume unit test failure fixes and Fakes for crdProvisioner (…
5813265 
…kubernetes-sigs#45)

* Fix for test run

* Adding fake crd provisioner

* Link fix

* Fixes for unit test cases

* Adding test case work with v1 and v2

* Setting up the complete flow from fake crdprovisioner to cloudprovisioner

* Lint fixes
jsafrane pushed a commit to jsafrane/azuredisk-csi-driver that referenced this issue Aug 10, 2023
@openshift-merge-robot
Merge pull request kubernetes-sigs#45 from bertinatto/rebase-v1.28.1
c36fe19 
OCPBUGS-15658: Update to v1.28.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkmsft kkmsft

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce CSI proxy calls kkmsft/azuredisk-csi-driver
5 participants
@feiskyer @andyzhangx @k8s-ci-robot @kkmsft @fejta-bot