Restore from SMB file share snapshot feature #136

andyzhangx · 2019-11-30T07:18:42Z

Is your feature request related to a problem?/Why is this needed

Describe the solution you'd like in detail

Currently azure file don't have a restore from snapshot SDK, need to implement that when it's available.
als see ref: https://github.com/vmware-tanzu/velero-plugin-for-microsoft-azure/issues/13#issuecomment-528861659

https://docs.microsoft.com/en-us/azure/backup/restore-afs
https://docs.microsoft.com/en-us/azure/backup/restore-azure-file-share-rest-api

Describe alternatives you've considered

Additional context

…visioned_reclaim_policy test: add e2e test "dynamically_provisioned_reclaim_policy_test"

fejta-bot · 2020-02-28T08:00:13Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2020-03-29T08:44:04Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

ialidzhikov · 2020-04-26T18:26:06Z

/remove-lifecycle rotten

ialidzhikov · 2020-04-26T18:28:58Z

@andyzhangx, does it make sense to put lifecycle/frozen on this issue?

andyzhangx · 2020-04-27T01:34:45Z

looks like there is still no snapshot restore API: https://docs.microsoft.com/en-us/rest/api/storageservices/snapshot-share

cc @RenaShahMSFT any progress on azure file snapshot API v2?

fejta-bot · 2020-07-26T02:02:43Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2020-10-24T03:09:30Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2020-11-23T03:53:02Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot · 2020-12-23T04:37:00Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

k8s-ci-robot · 2020-12-23T04:37:08Z

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Currently there is a limitation in Azure SDK and snapshots can only be created, not restored. We don't want users to be able to create snapshots when there is no use for them at this point. Disable snapshots by removing volume snapshot class resource and removing snapshotter sidecars. PR for tracking snapshot restore: kubernetes-sigs/azurefile-csi-driver#136

k8s-triage-robot · 2022-07-16T21:11:09Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

aslafy-z · 2022-07-17T19:23:03Z

/remove-lifecycle stale

akankshakumari393 · 2022-08-05T06:13:31Z

Do we know when can we have the support for restore feature?

k8s-triage-robot · 2022-11-03T06:19:20Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

aslafy-z · 2022-11-03T11:02:31Z

/remove-lifecycle stale

aslafy-z · 2022-11-23T10:23:15Z

@andyzhangx any news please?

Satsank · 2023-02-22T06:14:01Z

I apologize if this isn't allowed here. For those looking at alternatives to take Azure Files Snapshot and Restore, the team at CloudCasa.io added native support for it recently. Snapshots are taken using CSI driver, but the Restores are done using native AzureFiles Integration(must provide adequate permissions through an ARM template). It's a work around available through CloudCasa until the CSI driver natively supports this functionality. Hope this helps! https://cloudcasa.io/blog/automating-azure-files-restore-in-aks/

andyzhangx · 2023-02-22T10:15:24Z

I apologize if this isn't allowed here. For those looking at alternatives to take Azure Files Snapshot and Restore, the team at CloudCasa.io added native support for it recently. Snapshots are taken using CSI driver, but the Restores are done using native AzureFiles Integration(must provide adequate permissions through an ARM template). It's a work around available through CloudCasa until the CSI driver natively supports this functionality. Hope this helps! https://cloudcasa.io/blog/automating-azure-files-restore-in-aks/

@Satsank thanks for the sharing. Do you have more details about Restores are done using native AzureFiles Integration(must provide adequate permissions through an ARM template)? is it copy file one by one under one file share? Thanks.

0x113 · 2023-02-22T15:24:31Z

Hi @andyzhangx, I'm the developer behind automated Azure Files restore and I'll be more than happy to answer the questions.

Firstly, there's no need to provide any permissions with an ARM template for Azure Files restore. It's recommended for backing up and restoring AKS clusters infrastructure, but for just Azure Files, it's not mandatory.
As you may know, Azure files create a Kubernetes secret in the namespace of PVC in the following format: azure-storage-account-<storage-account-name>-secret. Our Azure Files mover looks for the right Secret, and it retrieves the credentials from there.

When it comes to the restore, CloudCasa uses the native Azure SDK to copy the files. Once CloudCasa finds the right snapshot for the PVC, it iterates through the files and copies them one by one to the destination file share. In the case of directories, it recreates the directory and then copies all the files.
I hope this helps!

aslafy-z · 2023-05-17T08:03:10Z

Any updates so far? Was there any progress on the Azure SDK side? Is there some public facing ticket for that SDK that we can track? Thanks

k8s-triage-robot · 2024-01-20T16:12:57Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

aslafy-z · 2024-01-20T16:57:45Z

/remove-lifecycle stale

andyzhangx added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Nov 30, 2019

levimm pushed a commit to levimm/azurefile-csi-driver that referenced this issue Dec 25, 2019

Merge pull request kubernetes-sigs#136 from ZeroMagic/dynamically_pro…

d3e79be

…visioned_reclaim_policy test: add e2e test "dynamically_provisioned_reclaim_policy_test"

andyzhangx added this to To do in azure file driver project Feb 14, 2020

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 28, 2020

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 29, 2020

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 26, 2020

ialidzhikov mentioned this issue Apr 26, 2020

CSI migration beginning with 1.19 gardener/gardener-extension-provider-azure#73

Merged

andyzhangx mentioned this issue Jul 22, 2020

Restored snapshot is empty #350

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2020

andyzhangx removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2020

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 24, 2020

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 23, 2020

k8s-ci-robot closed this as completed Dec 23, 2020

azure file driver project automation moved this from To do to Done Dec 23, 2020

andyzhangx reopened this Dec 23, 2020

azure file driver project automation moved this from Done to In progress Dec 23, 2020

andyzhangx removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 5, 2021

RomanBednar mentioned this issue Apr 20, 2022

add a note about azure file csi operator missing snapshot support openshift/openshift-docs#44735

Closed

andyzhangx mentioned this issue Jun 15, 2022

support azure file snapshot vmware-tanzu/velero#3151

Open

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 16, 2022

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 17, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 3, 2022

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 3, 2022

RomanBednar mentioned this issue Feb 8, 2023

Filesystem resize is required after snapshot restore / volume clone kubernetes/kubernetes#94929

Closed

6 tasks

andyzhangx changed the title ~~Restore from snapshot feature~~ Restore from SMB file share snapshot feature Feb 9, 2023

This was referenced Feb 10, 2023

wrong restoresize in volumesnapshots #1187

Closed

resourceGroup is not accepted for VolumeSnapshotClass #1186

Closed

andyzhangx mentioned this issue Oct 8, 2023

feat: add smb file restore from snapshot #1466

Merged

4 tasks

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2024

k8s-ci-robot closed this as completed in #1466 Apr 15, 2024

azure file driver project automation moved this from To do to Done Apr 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restore from SMB file share snapshot feature #136

Restore from SMB file share snapshot feature #136

andyzhangx commented Nov 30, 2019 •

edited

Loading

fejta-bot commented Feb 28, 2020

fejta-bot commented Mar 29, 2020

ialidzhikov commented Apr 26, 2020

ialidzhikov commented Apr 26, 2020

andyzhangx commented Apr 27, 2020

fejta-bot commented Jul 26, 2020

fejta-bot commented Oct 24, 2020

fejta-bot commented Nov 23, 2020

fejta-bot commented Dec 23, 2020

k8s-ci-robot commented Dec 23, 2020

k8s-triage-robot commented Jul 16, 2022

aslafy-z commented Jul 17, 2022

akankshakumari393 commented Aug 5, 2022

k8s-triage-robot commented Nov 3, 2022

aslafy-z commented Nov 3, 2022

aslafy-z commented Nov 23, 2022

Satsank commented Feb 22, 2023

andyzhangx commented Feb 22, 2023

0x113 commented Feb 22, 2023

aslafy-z commented May 17, 2023 •

edited

Loading

k8s-triage-robot commented Jan 20, 2024

aslafy-z commented Jan 20, 2024

Restore from SMB file share snapshot feature #136

Restore from SMB file share snapshot feature #136

Comments

andyzhangx commented Nov 30, 2019 • edited Loading

fejta-bot commented Feb 28, 2020

fejta-bot commented Mar 29, 2020

ialidzhikov commented Apr 26, 2020

ialidzhikov commented Apr 26, 2020

andyzhangx commented Apr 27, 2020

fejta-bot commented Jul 26, 2020

fejta-bot commented Oct 24, 2020

fejta-bot commented Nov 23, 2020

fejta-bot commented Dec 23, 2020

k8s-ci-robot commented Dec 23, 2020

k8s-triage-robot commented Jul 16, 2022

aslafy-z commented Jul 17, 2022

akankshakumari393 commented Aug 5, 2022

k8s-triage-robot commented Nov 3, 2022

aslafy-z commented Nov 3, 2022

aslafy-z commented Nov 23, 2022

Satsank commented Feb 22, 2023

andyzhangx commented Feb 22, 2023

0x113 commented Feb 22, 2023

aslafy-z commented May 17, 2023 • edited Loading

k8s-triage-robot commented Jan 20, 2024

aslafy-z commented Jan 20, 2024

andyzhangx commented Nov 30, 2019 •

edited

Loading

aslafy-z commented May 17, 2023 •

edited

Loading