Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unit tests on windows and add to pipeline #406

Merged
merged 6 commits into from Sep 7, 2020
Merged

fix: unit tests on windows and add to pipeline #406

merged 6 commits into from Sep 7, 2020

Conversation

mayankshah1607
Copy link
Contributor

@mayankshah1607 mayankshah1607 commented Sep 6, 2020 •
edited

Signed-off-by: Mayank Shah mayankshah1614@gmail.com

What type of PR is this?
/kind test
/kind cleanup

What this PR does / why we need it:
fix unit pkg/azurefile unit tests on Windows and enable them on the Github Actions Pipeline

Which issue(s) this PR fixes:

Fixes #404

Requirements:

Special notes for your reviewer:

Release note:

none

@mayankshah1607
fix: unit tests on windows and add to pipeline
0dd7bde 
Signed-off-by: Mayank Shah <mayankshah1614@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/test kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 6, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @mayankshah1607!

It looks like this is your first PR to kubernetes-sigs/azurefile-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/azurefile-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @mayankshah1607. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 6, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 6, 2020
@mayankshah1607
fix: imports
052e17a 
Signed-off-by: Mayank Shah <mayankshah1614@gmail.com>
@andyzhangx
Copy link
Member

/ok-to-test
/retest

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 6, 2020
@mayankshah1607
Copy link
Contributor Author

@andyzhangx It looks like TestCreateVolume/Create_disk_retruns_error is also failing on Windows. Should that be skipped too?

@andyzhangx
Copy link
Member

@andyzhangx It looks like TestCreateVolume/Create_disk_retruns_error is also failing on Windows. Should that be skipped too?

yes, thanks.

@mayankshah1607
rename to skipIfTestingOnWindows
50b6276 
Signed-off-by: Mayank Shah <mayankshah1614@gmail.com>
@mayankshah1607
skip TestCreateVolume/Create_disk_returns_error on Windows
53adc5d 
Signed-off-by: Mayank Shah <mayankshah1614@gmail.com>
@mayankshah1607
skip failing tests on Windows
a88d76b 
Signed-off-by: Mayank Shah <mayankshah1614@gmail.com>
@andyzhangx andyzhangx mentioned this pull request Sep 7, 2020
Closed
@mayankshah1607
skip TestNodeStageVolume on Windows
e2a6dbf 
Signed-off-by: Mayank Shah <mayankshah1614@gmail.com>
andyzhangx
andyzhangx approved these changes Sep 7, 2020
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

pkg/azurefile/nodeserver_test.go
@@ -236,6 +238,7 @@ func TestNodeUnpublishVolume(t *testing.T) {
}

func TestNodeStageVolume(t *testing.T) {
skipIfTestingOnWindows(t)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls re-enable this unit test on Windows later, thanks.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, mayankshah1607

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2020
@andyzhangx
Copy link
Member

/test pull-azurefile-csi-driver-e2e-vmss

@andyzhangx
Copy link
Member

could you squash all commits to one? git rebase -i HEAD~6

@k8s-ci-robot k8s-ci-robot merged commit 5763b6f into kubernetes-sigs:master Sep 7, 2020
@mayankshah1607 mayankshah1607 mentioned this pull request Oct 1, 2020
Closed
@mayankshah1607 mayankshah1607 mentioned this pull request Oct 27, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix unit test failure on Windows
3 participants
@mayankshah1607 @k8s-ci-robot @andyzhangx