Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick armclients 1.1 #1719

Merged

Conversation

lzhecheng
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

cherrypick #1612 #1550 #1613 #1556

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 13, 2022
Use GetThrottlingError() and GetRateLimitError() in azureclients

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
Add a new function GetResourceListID() and use other armclient ones
if possible.

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
* Use arm client
* Add UT

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 80.739% when pulling 1d36f39 on lzhecheng:cherrypick-armclients-1.1 into 4aa5e16 on kubernetes-sigs:release-1.1.

@MartinForReal
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit 73c1ff4 into kubernetes-sigs:release-1.1 May 16, 2022
@lzhecheng lzhecheng deleted the cherrypick-armclients-1.1 branch May 16, 2022 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants