Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:sparkles: Add MachineDeployment example #1060

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@vincepri
Copy link
Member

commented Aug 22, 2019

Signed-off-by: Vince Prignano vincepri@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Release note:


@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vincepri vincepri force-pushed the vincepri:examples-md branch from 520ca63 to 5235d45 Aug 22, 2019
examples/cluster/cluster.yaml Outdated Show resolved Hide resolved
examples/machinedeployment/machinedeployment.yaml Outdated Show resolved Hide resolved
@vincepri vincepri force-pushed the vincepri:examples-md branch 2 times, most recently from 1626e41 to 1d09d2d Aug 22, 2019
Signed-off-by: Vince Prignano <vincepri@vmware.com>
@vincepri vincepri force-pushed the vincepri:examples-md branch from 1d09d2d to f07db98 Aug 22, 2019
@rudoi

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit f33d166 into kubernetes-sigs:master Aug 22, 2019
5 of 6 checks passed
5 of 6 checks passed
tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation vincepri authorized
Details
pull-cluster-api-provider-aws-bazel-build Job succeeded.
Details
pull-cluster-api-provider-aws-bazel-integration Job succeeded.
Details
pull-cluster-api-provider-aws-bazel-test Job succeeded.
Details
pull-cluster-api-provider-aws-verify Job succeeded.
Details
export CLUSTER_NAME="${CLUSTER_NAME:-test1}"
export KUBERNETES_VERSION="${KUBERNETES_VERSION:-v1.14.4}"

This comment has been minimized.

Copy link
@detiber

detiber Aug 23, 2019

Member

We should probably update the other existing templates for the k8s version env variable as well.

name: ${CLUSTER_NAME}-md-0
spec:
instanceType: ${CONTROL_PLANE_MACHINE_TYPE}
iamInstanceProfile: "control-plane.cluster-api-provider-aws.sigs.k8s.io"

This comment has been minimized.

Copy link
@detiber

detiber Aug 23, 2019

Member

This should be nodes.cluster-api-provider-aws.sigs.k8s.io instead of control-plane

@vincepri vincepri referenced this pull request Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.