docs: updated Developer Guide with changes to make it more accurate

[rjsadow]

Signed-off-by: rjsadow richard.j.sadowski@gmail.com

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This PR merges in changes to make the Developer Guide and Development with Tilt documentation more accurate and clear to follow. It updates several minor issues and assumptions made in the live version.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3876

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: rsadowsk (aff27a31d6a16d4fcb89e88b02b27af8fa8a29f6)

[k8s-ci-robot]

Welcome @rsadowsk!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @rsadowsk. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Skarlso]

/ok-to-test

[Skarlso]

Why remove the v2? We are at v2. :)

[Skarlso]

Ah, never mind. This is for cloning.

[Skarlso]

I prefer this to be a move. Because whichever is first in the path will be used instead of the one on the location you copied to. That would be rather bad if you would update one but run the other.

[rjsadow]

Ok, and I agree with that. Through the dev environment setup guide there were several steps that called the clusterawsadm binary either through ./bin/ or assuming it was moved to your $PATH. I wanted to make the documentation consistent so I changed the mv to optional but it's easily changeable where we always do a move then assume the binary is in the path. I'll make those changes shortly.

[rjsadow]

@Skarlso, I pushed the changes for a mv to always happen and keep referencing clusterawsadm consistent as if it's in your path.

[Ankitasw]

/approve
cc @Skarlso for final review

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Ankitasw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Skarlso]

/lgtm

Thanks!