Skip to content

Commit

Permalink
use outboundlb name as the lb name in cloud config
Browse files Browse the repository at this point in the history
Signed-off-by: Ashutosh Kumar <sonasingh46@gmail.com>
  • Loading branch information
sonasingh46 committed Jan 21, 2023
1 parent 9e3506b commit 88a00d6
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
3 changes: 3 additions & 0 deletions controllers/helpers.go
Expand Up @@ -272,6 +272,7 @@ func newCloudProviderConfig(d azure.ClusterScoper) (controlPlaneConfig *CloudPro
SubnetName: subnet.Name,
RouteTableName: subnet.RouteTable.Name,
LoadBalancerSku: "Standard",
LoadBalancerName: d.OutboundLBName(infrav1.Node),
MaximumLoadBalancerRuleCount: 250,
UseManagedIdentityExtension: false,
UseInstanceMetadata: true,
Expand All @@ -292,6 +293,7 @@ func newCloudProviderConfig(d azure.ClusterScoper) (controlPlaneConfig *CloudPro
SubnetName: subnet.Name,
RouteTableName: subnet.RouteTable.Name,
LoadBalancerSku: "Standard",
LoadBalancerName: d.OutboundLBName(infrav1.Node),
MaximumLoadBalancerRuleCount: 250,
UseManagedIdentityExtension: false,
UseInstanceMetadata: true,
Expand Down Expand Up @@ -325,6 +327,7 @@ type CloudProviderConfig struct {
SubnetName string `json:"subnetName"`
RouteTableName string `json:"routeTableName"`
LoadBalancerSku string `json:"loadBalancerSku"`
LoadBalancerName string `json:"loadBalancerName"`
MaximumLoadBalancerRuleCount int `json:"maximumLoadBalancerRuleCount"`
UseManagedIdentityExtension bool `json:"useManagedIdentityExtension"`
UseInstanceMetadata bool `json:"useInstanceMetadata"`
Expand Down
12 changes: 12 additions & 0 deletions controllers/helpers_test.go
Expand Up @@ -484,6 +484,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": false,
"useInstanceMetadata": true
Expand All @@ -505,6 +506,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": false,
"useInstanceMetadata": true
Expand All @@ -524,6 +526,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": true,
"useInstanceMetadata": true
Expand All @@ -542,6 +545,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": true,
"useInstanceMetadata": true
Expand All @@ -561,6 +565,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": true,
"useInstanceMetadata": true,
Expand All @@ -580,6 +585,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": true,
"useInstanceMetadata": true,
Expand All @@ -601,6 +607,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": false,
"useInstanceMetadata": true
Expand All @@ -621,6 +628,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": false,
"useInstanceMetadata": true
Expand All @@ -641,6 +649,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": false,
"useInstanceMetadata": true,
Expand All @@ -666,6 +675,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": false,
"useInstanceMetadata": true,
Expand All @@ -691,6 +701,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": false,
"useInstanceMetadata": true,
Expand All @@ -716,6 +727,7 @@ const (
"subnetName": "foo-node-subnet",
"routeTableName": "foo-node-routetable",
"loadBalancerSku": "Standard",
"loadBalancerName": "foo",
"maximumLoadBalancerRuleCount": 250,
"useManagedIdentityExtension": false,
"useInstanceMetadata": true,
Expand Down

0 comments on commit 88a00d6

Please sign in to comment.