New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hub and conversion for AzureMachinePoolMachine #1799
Conversation
9d89b35
to
dfd8119
Compare
dfd8119
to
d6dbfaf
Compare
/retest System machine pools not ready |
/retest AMCP provisioned successfully, but the agent pools had no status and timed out. I feel like there might be a timing issue in the managed cluster creation flow. /cc @alexeldeib |
@devigned: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold Got 3 strikes with -exp job, and now I'm out. I'm going to run this test locally and see if I can root cause the issue. |
Weird...the code looks good to me. This was an error I had just noticed and was starting to hunt for, so thanks for pouncing on it first. |
I suspect that the AKS test failures are unrelated to this PR. See this thread in Slack: https://kubernetes.slack.com/archives/CEX9HENG7/p1635262955037000?thread_ts=1632943680.223800&cid=CEX9HENG7 |
/hold cancel As discussed in office hours, let's not gate this on the failing aks test as the failure is unrelated and aks clusters don't use AzureMachinePoolMachines. Test issue being addressed in #1800 |
"sigs.k8s.io/controller-runtime/pkg/conversion" | ||
) | ||
|
||
// ConvertTo converts this AzureMachinePoolMachine to the Hub version (v1beta1). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devigned I believe you also need to add conversion from v1alpha3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AzureMachinePoolMachines didn't exist in v1alpha3. They were introduced in v1alpha4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's what I was missing. Thank you.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR adds in conversion logic for
AzureMachinePoolMachines
. I think this was missed in the v1beta1 API introduction. Without this change, v1alpha4AzureMachinePoolMachines
will not be able to be converted to or from other API versions.Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: