Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfill updates from CAPA (continued) #254

Merged
merged 12 commits into from Aug 12, 2019

Conversation

@justaugustus
Copy link
Member

commented Jul 28, 2019

What this PR does / why we need it:

Continued work from #247.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Tacked a few more commits onto this, so I could test them together:

  • Update Kubernetes to v1.15.2 - c89149b
  • Update cluster-api to v0.1.9 and controller-tools to v0.1.12 - 42d1a7c
  • Update vendor for sig.k8s.io dependencies - 61d3881
  • Add additional retries for containerd downloads - 03229f2
  • Update Calico to v3.8.1 - a8c9753

Merge mode is set to merge commit, so they won't squashed in the history.

Release note:

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
- Add ownerRef to kubeconfig secret
- Move ProviderID set to machine_scope close
- Remove in-package NodeRef logic
- Scrub deadcode

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus justaugustus force-pushed the justaugustus:bf-2 branch from f3f8028 to e96012d Aug 11, 2019
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus justaugustus force-pushed the justaugustus:bf-2 branch from e96012d to 1550c97 Aug 12, 2019
@justaugustus justaugustus added this to In progress in Cluster API Azure via automation Aug 12, 2019
@justaugustus justaugustus changed the title [WIP] Backfill 2 Backfill updates from CAPA (continued) Aug 12, 2019
@justaugustus

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

@justaugustus: GitHub didn't allow me to assign the following users: CecileRobertMichon.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @soggiest @awesomenix @juan-lee @CecileRobertMichon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

/priority critical-urgent
/milestone v0.2

@k8s-ci-robot k8s-ci-robot added this to the v0.2 milestone Aug 12, 2019
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

Tacked a few more commits onto this, so I could test them together:

  • Update Kubernetes to v1.15.2 - c89149b
  • Update cluster-api to v0.1.9 and controller-tools to v0.1.12 - 42d1a7c
  • Update vendor for sig.k8s.io dependencies - 61d3881
  • Add additional retries for containerd downloads - 03229f2
  • Update Calico to v3.8.1 - a8c9753

Merge mode is set to merge commit, so they won't squashed in the history.

@soggiest

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit 588ac83 into kubernetes-sigs:master Aug 12, 2019
5 of 6 checks passed
5 of 6 checks passed
tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation justaugustus authorized
Details
pull-cluster-api-provider-azure-bazel-build Job succeeded.
Details
pull-cluster-api-provider-azure-bazel-test Job succeeded.
Details
pull-cluster-api-provider-azure-bazel-verify Job succeeded.
Details
pull-cluster-api-provider-azure-verify-boilerplate Job succeeded.
Details
Cluster API Azure automation moved this from In progress to Done (2019 - Q3) Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.