Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single stack IPv6 support #646

Merged
merged 5 commits into from Sep 25, 2020

Conversation

jsturtevant
Copy link
Contributor

@jsturtevant jsturtevant commented May 22, 2020

What this PR does / why we need it:
Adds ipv6 support. To use, set CLUSTER_TEMPLATE to cluster-template-ipv6.yaml.

kubectl --kubeconfig=./kubeconfig get nodes -o wide
NAME                              STATUS   ROLES    AGE   VERSION   INTERNAL-IP              EXTERNAL-IP   OS-IMAGE             KERNEL-VERSION     CONTAINER-RUNTIME
ipv6-test-2-control-plane-94sb4   Ready    master   29m   v1.18.8   2001:1234:5678:9abc::5   <none>        Ubuntu 18.04.5 LTS   5.3.0-1034-azure   containerd://1.3.4
ipv6-test-2-control-plane-c5kp6   Ready    master   25m   v1.18.8   2001:1234:5678:9abc::6   <none>        Ubuntu 18.04.5 LTS   5.3.0-1034-azure   containerd://1.3.4
ipv6-test-2-control-plane-zjxw4   Ready    master   32m   v1.18.8   2001:1234:5678:9abc::4   <none>        Ubuntu 18.04.5 LTS   5.3.0-1034-azure   containerd://1.3.4
ipv6-test-2-md-0-wgmtf            Ready    <none>   29m   v1.18.8   2001:1234:5678:9abd::5   <none>        Ubuntu 18.04.5 LTS   5.3.0-1034-azure   containerd://1.3.4
ipv6-test-2-md-0-z6lwq            Ready    <none>   29m   v1.18.8   2001:1234:5678:9abd::4   <none>        Ubuntu 18.04.5 LTS   5.3.0-1034-azure   containerd://1.3.4

Co-authored by @jsturtevant, @CecileRobertMichon and @aramase.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #318

Special notes for your reviewer:

Before merging needs:

  • unit tests fixed
  • e2e tests
  • docs

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Add single stack IPv6 support
Deprecate VNet and Subnet CirdrBlock in favor of CIDRBlocks

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress release-note labels May 22, 2020
@k8s-ci-robot k8s-ci-robot added area/provider/azure sig/cluster-lifecycle needs-ok-to-test labels May 22, 2020
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented May 22, 2020

Hi @jsturtevant. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes size/XL labels May 22, 2020
@jsturtevant jsturtevant changed the title Enable Ipv6 [WIP] Enable Ipv6 May 22, 2020
@devigned
Copy link
Contributor

@devigned devigned commented May 22, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test size/XXL and removed needs-ok-to-test size/XL labels May 22, 2020
@rbitia rbitia added this to In progress in Cluster API Azure May 29, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase label May 31, 2020
@k8s-ci-robot k8s-ci-robot added needs-rebase and removed needs-rebase labels Jun 5, 2020
@jsturtevant
Copy link
Contributor Author

@jsturtevant jsturtevant commented Jun 5, 2020

it is now working but currently has issues with route creation #682

@k8s-ci-robot k8s-ci-robot added needs-rebase and removed needs-rebase labels Jun 11, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase label Jun 25, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase label Sep 24, 2020
jsturtevant and others added 4 commits Sep 25, 2020
Update cluster.go

Update azurecluster_conversion.go
Co-Authored-By: Anish Ramasekar <10608509+aramase@users.noreply.github.com>

comments
@k8s-ci-robot k8s-ci-robot removed the needs-rebase label Sep 25, 2020
@CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Sep 25, 2020

rebased

@devigned
Copy link
Contributor

@devigned devigned commented Sep 25, 2020

/lgtm

Great collaboration folks!

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 25, 2020
@nader-ziada
Copy link
Member

@nader-ziada nader-ziada commented Sep 25, 2020

awesome work all, even though we will get probably get merge conflicts now :D

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nader-ziada

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Sep 25, 2020
@nader-ziada
Copy link
Member

@nader-ziada nader-ziada commented Sep 25, 2020

looks like something timed out

/test pull-cluster-api-provider-azure-e2e

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 25, 2020
@CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Sep 25, 2020

Had to change the ipv6 template to use key: worker-node-azure.json for the worker nodes after #955 merged.

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 25, 2020

@jsturtevant: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-provider-azure-apidiff c05182f link /test pull-cluster-api-provider-azure-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nader-ziada
Copy link
Member

@nader-ziada nader-ziada commented Sep 25, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit 110f084 into kubernetes-sigs:master Sep 25, 2020
12 of 14 checks passed
Cluster API Azure automation moved this from In progress to Done (2020 - Q2) Sep 25, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.4.9 milestone Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/provider/azure cncf-cla: yes lgtm ok-to-test release-note sig/cluster-lifecycle size/XXL
Projects
No open projects
Cluster API Azure
  
Done (2020 - Q2)
Development

Successfully merging this pull request may close these issues.

8 participants