Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Clean up manager YAML #257

Merged
merged 1 commit into from Oct 23, 2019

Conversation

@chuckha
Copy link
Member

chuckha commented Oct 23, 2019

Signed-off-by: Chuck Ha chuckh@vmware.com

What this PR does / why we need it:
For whatever reason trying to claim the file is a socket is a bad idea. Kubernetes doesn't think it's a socket but it works fine with this type removed. In addition the docker lib is not necessary.

These changes have already happened in current release.

Signed-off-by: Chuck Ha <chuckh@vmware.com>
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@detiber

This comment has been minimized.

Copy link
Member

detiber commented Oct 23, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4008ac8 into kubernetes-sigs:master Oct 23, 2019
3 checks passed
3 checks passed
cla/linuxfoundation chuckha authorized
Details
pull-cluster-api-provider-docker-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.