Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cluster api #147

Merged
merged 3 commits into from Dec 13, 2018
Merged

Update cluster api #147

merged 3 commits into from Dec 13, 2018

Conversation

scruplelesswizard
Copy link
Contributor

What this PR does / why we need it:
Updates cluster-api dependencies to v0.0.0-alpha.4

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #121

Special notes for your reviewer:
This PR changes us from tracking branch master on cluster-api to tracking tag 0.0.0-alpha.4
This has the side effect of changing the image tag we use for the cluster-api controller-manager from latest to 0.0.0-alpha.4
See kubernetes-sigs/cluster-api#635 for more information

Release note:

NONE

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaosaffe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 12, 2018
Copy link

@chrigl chrigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update looks ok and I was able to create a cluster, but still uses gcr.io/k8s-cluster-api/cluster-api-controller:latest.
Because we are not yet on kustomize, you also need to modify the image tag in:

@chrigl
Copy link

chrigl commented Dec 13, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2018
@k8s-ci-robot k8s-ci-robot merged commit 4908a8d into kubernetes-sigs:master Dec 13, 2018
flaper87 pushed a commit to flaper87/cluster-api-provider-openstack that referenced this pull request Jan 9, 2019
* format Gopkg.toml

* Update cluster-api to v0.0.0-alpha.4
Resolves kubernetes-sigs#121

* Update image tag in generate-yaml.sh
@scruplelesswizard scruplelesswizard deleted the update-cluster-api branch May 20, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update cluster-api as soon as #599 is in
3 participants