Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use env for bash #443

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@hchenxa
Copy link
Contributor

commented Aug 16, 2019

What this PR does / why we need it:
bash is not always in /bin, particularly on non-Linux systems. For example the OpenBSD system, it's in /usr/local/bin. so prefer to use #!/usr/bin/env bash.

refer https://stackoverflow.com/questions/21612980/why-is-usr-bin-env-bash-superior-to-bin-bash

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@hchenxa

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

@jichenjc

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Aug 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hchenxa, jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit d8bbdfc into kubernetes-sigs:master Aug 16, 2019
4 of 5 checks passed
4 of 5 checks passed
tide Not mergeable.
Details
cla/linuxfoundation hchenxa authorized
Details
pull-cluster-api-provider-openstack-check Job succeeded.
Details
pull-cluster-api-provider-openstack-make Job succeeded.
Details
pull-cluster-api-provider-openstack-test Job succeeded.
Details
prankul88 added a commit to prankul88/cluster-api-provider-openstack that referenced this pull request Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.