Simplify package layout #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch simplifies the package layout by moving all of the packages once located at "pkg/cloud/vsphere" directly into "pkg". The previous layout is a vestigial artifact of when the providers all lived in a single repository, and that is no longer the case.
k8s-ci-robot
added
the
cncf-cla: yes
|
/kind feature |
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akutz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
For comparison, CAPA has pkg/cloud/..., CAPG has cloud (no pkg). I think it's largely up to you / we don't have consistency across the CAP* projects at the moment. This seems like a reasonable change. |
|
looks like a reasonable change to me too |
k8s-ci-robot
added
the
lgtm
jayunit100
pushed a commit
to jayunit100/cluster-api-provider-vsphere
that referenced
this pull request
Feb 26, 2020
Signed-off-by: Chuck Ha <chuckh@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This patch simplifies the package layout by moving all of the packages located in
pkg/cloud/vspheredirectly intopkg. The previous layout is a vestigial artifact of when the providers all lived in a single repository, and that is no longer the case.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Special notes for your reviewer:
/assign @andrewsykim
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: