Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jsonpatch go module #1217

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@ncdc
Copy link
Contributor

commented Aug 1, 2019

What this PR does / why we need it:
Fix an issue in go.sum with the jsonpatch module checksum

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot requested review from detiber and justinsb Aug 1, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ncdc

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

@cblecker @BenTheElder is this the right thing to do?

@ncdc

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

/retest

Show resolved Hide resolved hack/update-vendor.sh Outdated
Fix jsonpatch go module
Signed-off-by: Andy Goldstein <goldsteina@vmware.com>

@ncdc ncdc force-pushed the ncdc:fix-jsonpatch-go-mod branch from e7698c3 to c31a7c8 Aug 1, 2019

@detiber
Copy link
Member

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 1, 2019

@detiber detiber referenced this pull request Aug 1, 2019

Merged

Add AWSCluster #942

@k8s-ci-robot k8s-ci-robot merged commit 83d4c2a into kubernetes-sigs:master Aug 1, 2019

10 of 12 checks passed

Header rules No header rules processed
Details
Pages changed 19 new files uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 3 redirect rules processed
Details
cla/linuxfoundation ncdc authorized
Details
deploy/netlify Deploy preview ready!
Details
pull-cluster-api-build Job succeeded.
Details
pull-cluster-api-integration Job succeeded.
Details
pull-cluster-api-make Job succeeded.
Details
pull-cluster-api-test Job succeeded.
Details
pull-cluster-api-vendor-in-sync Job succeeded.
Details
tide In merge pool.
Details

@detiber detiber referenced this pull request Aug 2, 2019

Merged

Get repo into usable shape #62

@kron4eg kron4eg referenced this pull request Aug 6, 2019

Open

Please release v2.0.1 #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.