Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Rename ErrorMessage and ErrorReason to FailureMessage and FailureReason #1776

Merged
merged 1 commit into from Nov 15, 2019

Conversation

@noamran
Copy link
Contributor

noamran commented Nov 14, 2019

What this PR does / why we need it:
Renames ErrorMessage and ErrorReason fields to FailureMessage and FailureReason in Cluster, Machine and MachineSet
Which issue(s) this PR fixes :
Fixes #1670

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 14, 2019

Hi @noamran. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from detiber and moshloop Nov 14, 2019
@noamran noamran force-pushed the noamran:1670 branch from aab3e9d to dc48756 Nov 14, 2019
@noamran noamran force-pushed the noamran:1670 branch 3 times, most recently from e2d5bef to 4f52174 Nov 14, 2019
@vincepri

This comment has been minimized.

Copy link
Member

vincepri commented Nov 14, 2019

/assign

@vincepri

This comment has been minimized.

Copy link
Member

vincepri commented Nov 14, 2019

/milestone v0.3.0

@k8s-ci-robot k8s-ci-robot added this to the v0.3.0 milestone Nov 14, 2019
@vincepri

This comment has been minimized.

Copy link
Member

vincepri commented Nov 14, 2019

/ok-to-test

@noamran noamran force-pushed the noamran:1670 branch 4 times, most recently from 9dd5859 to f89d83b Nov 14, 2019
Copy link
Member

vincepri left a comment

/approve
/assign @ncdc

for final lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: noamran, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@noamran

This comment has been minimized.

Copy link
Contributor Author

noamran commented Nov 14, 2019

/hold
Need to push some more changes.

@noamran noamran force-pushed the noamran:1670 branch from f89d83b to 7bcd3cd Nov 15, 2019
@noamran

This comment has been minimized.

Copy link
Contributor Author

noamran commented Nov 15, 2019

/hold cancel

@@ -71,13 +71,13 @@ type KubeadmConfigStatus struct {
// +optional
BootstrapData []byte `json:"bootstrapData,omitempty"`

// ErrorReason will be set on non-retryable errors

This comment has been minimized.

Copy link
@ncdc

ncdc Nov 15, 2019

Contributor

This would be a breaking change to the cabpk v1alpha2 types. If we want to make this change, we need a new v1alpha3 group plus conversions.

@ncdc

This comment has been minimized.

Copy link
Contributor

ncdc commented Nov 15, 2019

/hold
because of the need for cabpk v1a3

@ncdc

This comment has been minimized.

Copy link
Contributor

ncdc commented Nov 15, 2019

/approve cancel
because of the need for cabpk v1a3

@vincepri

This comment has been minimized.

Copy link
Member

vincepri commented Nov 15, 2019

Let’s remove the changes to v1a2 cabpk types from this PR and tackle that separately?

@ncdc

This comment has been minimized.

Copy link
Contributor

ncdc commented Nov 15, 2019

@vincepri SGTM

@noamran noamran force-pushed the noamran:1670 branch from 7bcd3cd to 8143d3a Nov 15, 2019
@noamran

This comment has been minimized.

Copy link
Contributor Author

noamran commented Nov 15, 2019

Opened #1783 for creating CABPK v1alpha3 types.

@ncdc

This comment has been minimized.

Copy link
Contributor

ncdc commented Nov 15, 2019

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm and removed do-not-merge/hold labels Nov 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit ee8f353 into kubernetes-sigs:master Nov 15, 2019
11 of 12 checks passed
11 of 12 checks passed
tide Not mergeable. Needs lgtm label.
Details
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 3 redirect rules processed
Details
cla/linuxfoundation noamran authorized
Details
deploy/netlify Deploy preview ready!
Details
pull-cluster-api-build Job succeeded.
Details
pull-cluster-api-integration Job succeeded.
Details
pull-cluster-api-make Job succeeded.
Details
pull-cluster-api-test Job succeeded.
Details
pull-cluster-api-verify Job succeeded.
Details
@noamran noamran deleted the noamran:1670 branch Jan 9, 2020
@noamran noamran mentioned this pull request Jan 22, 2020
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.