Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding note about envsubst application #1815

Merged
merged 1 commit into from Dec 3, 2019

Conversation

@jduncan-rva
Copy link
Contributor

jduncan-rva commented Nov 29, 2019

馃摉

What this PR does / why we need it:

Small add-in to the quickstart guide to help lower the barrier for novice users. At least on Mac OS, envsubst isn't installed by default, and is provided using Brew with gettext. That relationship isn't obvious (at least not to me). An additional note to handle the dependency will help prevent a new user from tripping up during the quickstart guide.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 29, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 29, 2019

Welcome @jduncan-rva!

It looks like this is your first PR to kubernetes-sigs/cluster-api 馃帀. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 馃槂

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 29, 2019

Hi @jduncan-rva. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jduncan-rva

This comment has been minimized.

Copy link
Contributor Author

jduncan-rva commented Nov 29, 2019

/assign @detiber

Copy link
Member

vincepri left a comment

/approve
/ok-to-test

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jduncan-rva, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vincepri

This comment has been minimized.

Copy link
Member

vincepri commented Dec 2, 2019

@jduncan-rva Need to fix your commit to include your github email

@jduncan-rva jduncan-rva force-pushed the jduncan-rva:master branch from 7eb09c4 to e64b877 Dec 3, 2019
@jduncan-rva

This comment has been minimized.

Copy link
Contributor Author

jduncan-rva commented Dec 3, 2019

@jduncan-rva Need to fix your commit to include your github email

fixed. stupid typos. fixed on my checkout and force-pushed the update.

@detiber

This comment has been minimized.

Copy link
Member

detiber commented Dec 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 3, 2019
@detiber

This comment has been minimized.

Copy link
Member

detiber commented Dec 3, 2019

/test pull-cluster-api-integration

@k8s-ci-robot k8s-ci-robot merged commit 3f6618c into kubernetes-sigs:master Dec 3, 2019
11 of 12 checks passed
11 of 12 checks passed
tide Not mergeable. Retesting: pull-cluster-api-integration
Details
Header rules No header rules processed
Details
Pages changed 5 new files uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 3 redirect rules processed
Details
cla/linuxfoundation jduncan-rva authorized
Details
deploy/netlify Deploy preview ready!
Details
pull-cluster-api-build Job succeeded.
Details
pull-cluster-api-integration Job succeeded.
Details
pull-cluster-api-make Job succeeded.
Details
pull-cluster-api-test Job succeeded.
Details
pull-cluster-api-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.