Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ infrastructure provider DigitaloOcean was renamed to digitalocean (previously do) #3809

Merged
merged 1 commit into from Oct 16, 2020
Merged

⚠️ infrastructure provider DigitaloOcean was renamed to digitalocean (previously do) #3809

merged 1 commit into from Oct 16, 2020

Conversation

prksu
Copy link
Contributor

@prksu prksu commented Oct 16, 2020

What this PR does / why we need it:
This PR rename digitalocean infrastructure provider name from do to digitalocean to be matched with cluster-api-provider-digitalocean manifests labels and clusterctl-settings.json

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/cc @kubernetes-sigs/cluster-api-provider-digitalocean-maintainers

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 16, 2020 •
edited

@prksu: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-apidiff-main c7c0fd7 link /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cpanato
cpanato approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

i dont think that will cause any breaking

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2020
@cpanato
Copy link
Member

cpanato commented Oct 16, 2020

/assign @fabriziopandini

@cpanato
Copy link
Member

cpanato commented Oct 16, 2020

/test pull-cluster-api-test-main

xmudrii
xmudrii approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fabriziopandini
Copy link
Member

/lgtm
This is a user-facing change so I recommend renaming the PR into :warning infrastructure provider DigitaloOcean was renamed to digitalocean (previously do) or something that stands up when reading the release notes
Also, are you planning to back port this to the v0.3 series?

@prksu
Copy link
Contributor Author

prksu commented Oct 16, 2020

/retitle ⚠️ infrastructure provider DigitaloOcean was renamed to digitalocean (previously do)

@k8s-ci-robot k8s-ci-robot changed the title 🌱 fix digitalocean infrastructure provider name ⚠️ infrastructure provider DigitaloOcean was renamed to digitalocean (previously do) Oct 16, 2020
@prksu
Copy link
Contributor Author

prksu commented Oct 16, 2020

@fabriziopandini yes, we are also planning to backport this to v0.3 release

@prksu
Copy link
Contributor Author

prksu commented Oct 16, 2020

/area clusterctl

@k8s-ci-robot k8s-ci-robot added the area/clusterctl Issues or PRs related to clusterctl label Oct 16, 2020
@fabriziopandini
Copy link
Member

@vincepri for the backporting bits

@vincepri
Copy link
Member

Cherry-pick + open a different PR based on release-0.3 branch

/approve

@vincepri
Copy link
Member

/milestone v0.4.0

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Oct 16, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit c1a858c into kubernetes-sigs:master Oct 16, 2020
@prksu prksu deleted the cctl-fix-do-provider branch October 16, 2020 16:51
@prksu prksu mentioned this pull request Oct 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@xmudrii xmudrii xmudrii approved these changes

Assignees

@cpanato cpanato

@fabriziopandini fabriziopandini

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@prksu @k8s-ci-robot @cpanato @fabriziopandini @vincepri @xmudrii