馃尡 Change a few more references from master branch to main branch #5312
Conversation
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
k8s-ci-robot
added
cncf-cla: yes
|
/assign @CecileRobertMichon |
| @@ -62,12 +62,12 @@ Some templating tools that can be used to manage your templates. | |||
| * Cue - Cue Data Constraint Language. | |||
| * Source: https://github.com/cuelang/cue | |||
| * Dhall - Dhall Programming Configuration Language. | |||
| * Source: https://github.com/dhall-lang/dhall-lang/blob/master/README.md | |||
| * Source: https://github.com/dhall-lang/dhall-lang | |||
There was a problem hiding this comment.
This change technically changes the link, we are now pointing to the repo root rather than the readme explicitly. Does this matter?
There was a problem hiding this comment.
I don't think it really matters as the repo root also shows the README, but it's totally fine for me if we want to change it back
There was a problem hiding this comment.
I don't really have a strong opinion, but my thought was basically, when this was introduced, was there a deliberate intention to make it point to the readme file directly 馃
There was a problem hiding this comment.
Yup, let's see if anyone else remembers :)
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
What this PR does / why we need it: #3280
Just found a broken e2e test (will be fixed in #5313), so I thought I also cleanup some other occurrences.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #