Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Fuzzing: Add report #6842

Closed
wants to merge 1 commit into from

Conversation

AdamKorcz
Copy link

Signed-off-by: AdamKorcz adam@adalogics.com

Adds the report for the fuzzing work that was done in collaboration with the CNCF and Ada Logics.

docs/reports is merely a suggestion. Feel free to recommend a different location.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Signed-off-by: AdamKorcz <adam@adalogics.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 6, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @AdamKorcz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign enxebre after the PR has been reviewed.
You can assign the PR to them by writing /assign @enxebre in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 6, 2022
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this repo is the best place for keeping a report like this - pdf, static. Is there some other location to host the report that we could link to?

@PushkarJ wondering if SIG security has any specific repo or recommendations for reports like this?

@PushkarJ
Copy link
Member

PushkarJ commented Jul 6, 2022

Good point Killian. It might make sense to host the report under github.com/kubernetes/sig-security/sig-security-assessments/cluster-api but will let @aladewberry confirm when she is back as the owner of that directory.

@AdamKorcz
Copy link
Author

I don't think this repo is the best place for keeping a report like this - pdf, static. Is there some other location to host the report that we could link to?

@PushkarJ wondering if SIG security has any specific repo or recommendations for reports like this?

Usually projects store these reports in their repositories. Some examples for reference are:
etcd: https://github.com/etcd-io/etcd/blob/main/security/FUZZING_AUDIT_2022.PDF
envoy: https://github.com/envoyproxy/envoy/blob/main/docs/security/audit_fuzzer_adalogics_2021.pdf
linkerd-proxy: https://github.com/linkerd/linkerd2-proxy/blob/main/docs/reports/linkerd2-proxy-fuzzing-report.pdf
vitess: https://github.com/vitessio/vitess/blob/main/doc/VIT-02-report-fuzzing-audit.pdf

From our (Ada Logics) side, we have no preference.

@killianmuldoon
Copy link
Contributor

/hold
Let's wait to figure out if github.com/kubernetes/sig-security/sig-security-assessments/cluster-api is the right place for this report.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2022
@DavidKorczynski
Copy link

DavidKorczynski commented Jul 12, 2022

any updates on this one? Just saw we're waiting for @aladewberry

@aladewberry
Copy link

@DavidKorczynski @killianmuldoon Agreed with @PushkarJ that github.com/kubernetes/sig-security/sig-security-assessments/cluster-api is the appropriate place for this to be stored. Is the next step for me to put it there? Let me know!

@killianmuldoon
Copy link
Contributor

I just opened a PR on the sig-security repo at kubernetes/sig-security#52. Once everyone's happy we can close this PR and I'll find a suitable place to put a link to this in the CAPI book. Thanks for all the hard work!

@killianmuldoon
Copy link
Contributor

Report is now merged in sig-security 🙂

/close

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: Closed this PR.

In response to this:

Report is now merged in sig-security 🙂

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants