Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @rainleander! |
/check-cla |
This tweet may not be relevant anymore... Can I help moderate these pulls? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOVE this! Wdyt @kaslin?
Hey @rainleander, we'd love to get your involvement here. @kaslin is lead and we could talk you coming in as shadow or another contributor in general. |
Definitely; I'm comfortable doing either! |
Ah yeah, I'm so sorry I missed this back when you submitted it! KubeCon threw me off. But yes, I love it! I'm tempted to just go ahead and send it anyway. I can add a reply on it with more context. |
Yeah, it's a tornado. Definitely reply to add context once it goes through. I can do the same! |
Sorry about the additional delay on this, we're definitely learning some about our processes here! We just introduced some new automation to the repo which broke things for a minute, so this tweet will serve an additional purpose as a test in the process of our automation updates! Thank you, @rainleander for unintentionally becoming the first member of our automation testing team! XD (This is a joke about the testing team, but really thank you! This PR makes me so happy.) |
No worries at all; let's get it all going smoothly! |
Hey @rainleander Thanks for being patient. The workflow should be fixed now. Can you try rebasing this PR on the latest master branch? Thanks! |
Done! |
Correct me if I am wrong, I don't see the rebase changes. Can you check again? |
Weird. Did it again? |
I can the new changes now. The workflow is working. The tweet will go out once we merge this. Just an FYI for future purposes: It is advised to not do a merge rebase if possible, it creates an additional commit. A normal rebase is preferred. |
/approve /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaslin, rainleander The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
No description provided.