Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Create 07-05-2021-first-tweet.tweet #38

Merged
merged 2 commits into from Jul 8, 2021

Conversation

rainleander
Copy link
Contributor

No description provided.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 7, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @rainleander!

It looks like this is your first PR to kubernetes-sigs/contributor-tweets 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/contributor-tweets has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 7, 2021
@rainleander
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 7, 2021
@rainleander
Copy link
Contributor Author

This tweet may not be relevant anymore... Can I help moderate these pulls?

Copy link
Contributor

@mbbroberg mbbroberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE this! Wdyt @kaslin?

@mbbroberg
Copy link
Contributor

Hey @rainleander, we'd love to get your involvement here. @kaslin is lead and we could talk you coming in as shadow or another contributor in general.

@rainleander
Copy link
Contributor Author

Hey @rainleander, we'd love to get your involvement here. @kaslin is lead and we could talk you coming in as shadow or another contributor in general.

Definitely; I'm comfortable doing either!

@kaslin
Copy link
Contributor

kaslin commented Jun 9, 2021

Ah yeah, I'm so sorry I missed this back when you submitted it! KubeCon threw me off. But yes, I love it! I'm tempted to just go ahead and send it anyway. I can add a reply on it with more context.

@rainleander
Copy link
Contributor Author

Yeah, it's a tornado. Definitely reply to add context once it goes through. I can do the same!

@kaslin
Copy link
Contributor

kaslin commented Jun 18, 2021

Sorry about the additional delay on this, we're definitely learning some about our processes here! We just introduced some new automation to the repo which broke things for a minute, so this tweet will serve an additional purpose as a test in the process of our automation updates!

Thank you, @rainleander for unintentionally becoming the first member of our automation testing team! XD (This is a joke about the testing team, but really thank you! This PR makes me so happy.)

@rainleander
Copy link
Contributor Author

No worries at all; let's get it all going smoothly!

@rajula96reddy
Copy link
Contributor

rajula96reddy commented Jul 7, 2021

Hey @rainleander Thanks for being patient. The workflow should be fixed now. Can you try rebasing this PR on the latest master branch? Thanks!

@rainleander
Copy link
Contributor Author

Hey @rainleander Thanks for being patient. The workflow should be fixed now. Do you rebasing this PR on the latest master branch? Thanks!

Done!

@rajula96reddy
Copy link
Contributor

Hey @rainleander Thanks for being patient. The workflow should be fixed now. Do you rebasing this PR on the latest master branch? Thanks!

Done!

Correct me if I am wrong, I don't see the rebase changes. Can you check again?
https://github.com/rainleander/contributor-tweets/tree/patch-1 still says "This branch is 1 commit ahead, 13 commits behind kubernetes-sigs:master. "

@rainleander
Copy link
Contributor Author

Weird. Did it again?

@mrbobbytables mrbobbytables added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 8, 2021
@rajula96reddy
Copy link
Contributor

Weird. Did it again?

I can the new changes now. The workflow is working. The tweet will go out once we merge this.

Just an FYI for future purposes: It is advised to not do a merge rebase if possible, it creates an additional commit. A normal rebase is preferred.

@kaslin
Copy link
Contributor

kaslin commented Jul 8, 2021

/approve /lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaslin, rainleander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2021
@kaslin
Copy link
Contributor

kaslin commented Jul 8, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 08db7bb into kubernetes-retired:master Jul 8, 2021
@rainleander rainleander deleted the patch-1 branch July 9, 2021 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants