✨ Add controller workqueue option #2767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
Member
Author
|
cc @sebgl /assign @alvaroaleman |
Member
Author
|
/cc @fabriziopandini @chrischdi Makes it possible to pass in alternative queue implementations |
sbueringer
force-pushed
the
pr-add-queue-option
branch
from
dcdb499 to
39ed0d5
Compare
alvaroaleman
approved these changes
Apr 10, 2024
Member
alvaroaleman
left a comment
alvaroaleman
left a comment
There was a problem hiding this comment.
Looks good to me, leaving a hold in case you want to wait for further feedback, if not, feel free to cancel it
/hold
k8s-ci-robot
added
do-not-merge/hold
Contributor
|
LGTM label has been added. Git tree hash: e9710eb26c1509bace62c462b330e576ae31ef74
|
Member
Author
|
/assign @vincepri |
vincepri
reviewed
Apr 10, 2024
Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-add-queue-option
branch
from
39ed0d5 to
6e23721
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
size/L
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: bff80f2abc8ca783176b9bf7d3d4894af4dadb59
|
k8s-ci-robot
removed
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer buringerst@vmware.com