New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch admissionwebhook-1.11 back to master #143

Merged
merged 11 commits into from Sep 14, 2018

Conversation

Projects
None yet
3 participants
@mengqiy
Contributor

mengqiy commented Sep 14, 2018

All of the commits has been reviewed before.
This PR is merging branch admissionwebhook-1.11 back to master.
This PR has resolved conflict happend in #142

@k8s-ci-robot k8s-ci-robot requested review from droot and pwittrock Sep 14, 2018

@mengqiy mengqiy requested review from DirectXMan12 and removed request for droot and pwittrock Sep 14, 2018

@mengqiy mengqiy requested a review from droot Sep 14, 2018

@mengqiy mengqiy requested a review from pwittrock Sep 14, 2018

@DirectXMan12

This comment has been minimized.

Show comment
Hide comment
@DirectXMan12

DirectXMan12 Sep 14, 2018

Contributor

/lgtm
/approve

Contributor

DirectXMan12 commented Sep 14, 2018

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Sep 14, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Sep 14, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8d93cc7 into kubernetes-sigs:master Sep 14, 2018

3 checks passed

cla/linuxfoundation mengqiy authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
tide In merge pool.
Details

@mengqiy mengqiy deleted the mengqiy:admissionwebhook-1.11 branch Sep 14, 2018

@mengqiy mengqiy referenced this pull request Sep 14, 2018

Closed

Admissionwebhook 1.11 #142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment