New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support register arbitrary http.Handler in Server #152

Merged
merged 1 commit into from Sep 19, 2018

Conversation

Projects
None yet
3 participants
@mengqiy
Contributor

mengqiy commented Sep 19, 2018

With this change, users can register arbitrary http.Handler in Server, e.g. /version endpoint with a handler, /metrics with a Prometheus handler or other monitoring system.

@mengqiy mengqiy requested review from DirectXMan12 and droot Sep 19, 2018

@k8s-ci-robot k8s-ci-robot requested a review from pwittrock Sep 19, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Sep 19, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Sep 19, 2018

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5373e8e into kubernetes-sigs:master Sep 19, 2018

3 checks passed

cla/linuxfoundation mengqiy authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
tide In merge pool.
Details

@mengqiy mengqiy deleted the mengqiy:arbitraty_http_handler branch Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment