Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 fake-client: extend builder with an option to set a RESTMapper #1686

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #1683

/assign sbueringer

Signed-off-by: Stefan B眉ringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 7, 2021
@sbueringer
Copy link
Member

sbueringer commented Oct 7, 2021

/lgtm
/assign @alvaroaleman

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2021
@alvaroaleman
Copy link
Member

alvaroaleman commented Oct 7, 2021

/retitle 锟 fake-client: extend builder with an option to set a RESTMapper

We should make our release tooling able to deal with the leading branchprefix 馃槵

@k8s-ci-robot k8s-ci-robot changed the title [release-0.10] 馃尡 fake-client: extend builder with an option to set a RESTMapper 锟 fake-client: extend builder with an option to set a RESTMapper Oct 7, 2021
@alvaroaleman alvaroaleman changed the title 锟 fake-client: extend builder with an option to set a RESTMapper 馃尡 fake-client: extend builder with an option to set a RESTMapper Oct 7, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 307b8e1 into kubernetes-sigs:release-0.10 Oct 7, 2021
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants