Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 pkg: envtest: komega: fix UpdateStatus & typos in godoc #1862

Conversation

damdo
Copy link
Contributor

@damdo damdo commented Apr 8, 2022

  • It fixes envtest's komega UpdateStatus() godoc example to reference the corresponding function call (UpdateStatus()) rather than the Update() one.
  • It fixes some typos in envtest's komega godoc examples by replacing Scucceed() with Succeed().

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 8, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 8, 2022

Welcome @damdo!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 馃帀. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 馃槂

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 8, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 8, 2022

Hi @damdo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from alexeldeib Apr 8, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 8, 2022
@k8s-ci-robot k8s-ci-robot requested a review from droot Apr 8, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 8, 2022
@damdo damdo changed the title 馃悰 pkg: envtest: komega: fix UpdateStatus godoc 馃悰 pkg: envtest: komega: fix UpdateStatus & typos in godoc Apr 8, 2022
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

/lgtm

Thanks for keeping things tidy

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2022
@damdo
Copy link
Contributor Author

damdo commented Apr 8, 2022

/assign @vincepri

@damdo
Copy link
Contributor Author

damdo commented Apr 14, 2022

/assign @schrej

@schrej
Copy link
Member

schrej commented Apr 14, 2022

Thank you!
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, schrej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0a4d154 into kubernetes-sigs:master Apr 14, 2022
8 of 9 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.10.x milestone Apr 14, 2022
alvaroaleman pushed a commit to alvaroaleman/controller-runtime that referenced this issue Apr 14, 2022
鈥-fix-updatestatus-godoc

馃悰 pkg: envtest: komega: fix UpdateStatus & typos in godoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants