Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 don't override global log in builder #1911

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #1907

/assign alvaroaleman

The recent change
kubernetes-sigs@598978c#diff-e77b9468ab935d5ea4d5cdae3b994114bada17df0001570e4b1436419afd50ccR312
introduced a bug by overriding `log` with the log created by a builder,
resulting in all logs produced by `controller-runtime` having
`controller`, `controllerGroup` and `controllerKind` set to the last
created controller.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes size/XS labels May 19, 2022
@k8s-ci-robot k8s-ci-robot requested review from alexeldeib and gerred May 19, 2022
@alvaroaleman alvaroaleman changed the title [release-0.12] 🐛 don't override global log in builder 🐛 don't override global log in builder May 19, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm label May 19, 2022
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented May 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label May 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1efdbd7 into kubernetes-sigs:release-0.12 May 19, 2022
7 of 8 checks passed
@hikhvar
Copy link

@hikhvar hikhvar commented Jun 21, 2022

Any plans to release a bugfix release of the v0.12 release branch? This is currently messing up our logs.

@sbueringer
Copy link
Member

@sbueringer sbueringer commented Jun 21, 2022

+1 would be nice to have a v0.12.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cncf-cla: yes lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants