Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix vendor logr #71

Merged
merged 1 commit into from
Jul 6, 2018
Merged

fix vendor logr #71

merged 1 commit into from
Jul 6, 2018

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Jul 6, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 6, 2018
@pwittrock
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2018
@pwittrock pwittrock added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2018
@k8s-ci-robot k8s-ci-robot merged commit 120b59a into kubernetes-sigs:master Jul 6, 2018
@mengqiy mengqiy deleted the logr branch July 6, 2018 20:57
@grantr
Copy link
Contributor

grantr commented Jul 10, 2018

I think this PR missed updating a reference to zaplogr:

controller-runtime/pkg/runtime/log/log.go

Line 28 in 6865d0a

return zaplogr.NewLogger(zapLog)

@mengqiy
Copy link
Member Author

mengqiy commented Jul 10, 2018

Not true.
zaplogr is referencing the package name https://github.com/go-logr/zapr/blob/7719b12d150e27231f2c113e7d40901f35e92287/zaplogr.go#L38 in "github.com/go-logr/zapr" :)

@grantr
Copy link
Contributor

grantr commented Jul 11, 2018

Oh I see. The bug is actually in go-logr/zapr, which is documented with the package name and pathzapr but is actually called zaplogr. I'm surprised Go doesn't consider that a bug, or at least a vet error. Thanks for clearing up my confusion @mengqiy!

@grantr grantr mentioned this pull request Jul 11, 2018
Closed
@droot droot mentioned this pull request Jul 13, 2018
Closed
justinsb pushed a commit to justinsb/controller-runtime that referenced this pull request Dec 7, 2018
@k8s-ci-robot
Merge pull request kubernetes-sigs#71 from mengqiy/logr
0d7832f 
fix vendor logr
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
Merge pull request #71 from Liujingfang1/kube
88f0bdd 
update validation for core types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@pwittrock pwittrock

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mengqiy @pwittrock @grantr @droot @k8s-ci-robot