New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crd: add finalizers support in CRD generation #82

Merged
merged 1 commit into from Sep 21, 2018

Conversation

Projects
None yet
4 participants
@droot
Contributor

droot commented Sep 20, 2018

@droot droot requested a review from fanzhangio Sep 20, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Sep 20, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Sep 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fanzhangio

/lgtm

@@ -370,9 +376,6 @@ func parseScaleParams(t *types.Type) (map[string]string, error) {
if len(path) < 2 {
return nil, fmt.Errorf(jsonPathError)
}
for _, s := range path {
fmt.Printf("\n[debug] %s", s)
}

This comment has been minimized.

@fanzhangio

fanzhangio Sep 21, 2018

Member

Thank you @droot . this is going to be deleted in my separate PR.

@fanzhangio

fanzhangio Sep 21, 2018

Member

Thank you @droot . this is going to be deleted in my separate PR.

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 21, 2018

@k8s-ci-robot k8s-ci-robot merged commit d48c295 into kubernetes-sigs:master Sep 21, 2018

3 checks passed

cla/linuxfoundation droot authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment