Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit k8s Event When a Pod Is Evicted #166

Closed
seanmalloy opened this issue Jul 5, 2019 · 5 comments
Closed

Emit k8s Event When a Pod Is Evicted #166

seanmalloy opened this issue Jul 5, 2019 · 5 comments

Comments

@seanmalloy
Copy link
Member

It would be useful if the descheduler emitted a k8s event when it successfully evicts a pod. The event should be created in same namespace as the evicted pod.
@seanmalloy
Copy link
Member Author

It looks like the best place to do this would here ...

https://github.com/kubernetes-incubator/descheduler/blob/master/pkg/descheduler/evictions/evictions.go#L50-L51

@seanmalloy
Copy link
Member Author

I would be happy to submit a pull request to add this feature.

@kivagant-ba
Copy link

@seanmalloy , so when will you be happy? ;)

seanmalloy added a commit to KohlsTechnology/descheduler that referenced this issue Sep 20, 2019
@seanmalloy
WIP: add k8s events support
e0ad178 
This code does not compile yet. Fixes kubernetes-sigs#166.
@seanmalloy seanmalloy mentioned this issue Sep 20, 2019
Merged
seanmalloy added a commit to KohlsTechnology/descheduler that referenced this issue Oct 18, 2019
@seanmalloy
Add k8s events support
a171df3 
Create k8s events when a pod is successfully evicted.

Fixes kubernetes-sigs#166.
@seanmalloy
Copy link
Member Author

seanmalloy commented Oct 18, 2019 •
edited

I created #183 to implement this.

seanmalloy added a commit to KohlsTechnology/descheduler that referenced this issue Nov 16, 2019
@seanmalloy
Create k8s event when a pod is successfully evicted
6881991 
Fixes kubernetes-sigs#166
@seanmalloy
Copy link
Member Author

Pull request #183 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanmalloy @kivagant-ba