Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Descheduling framework PoC #781

Closed

Conversation

ingvagabund
Copy link
Contributor

@ingvagabund ingvagabund commented Apr 6, 2022

  • providing PoC for Descheduler Framework Proposal #753
  • the same strategy can be configured differently through different profiles: Multiple descheduler strategies of the same type #486
  • following up on the v1alpha2 config: Multiple descheduler strategies of the same type #486
    Example:
    apiVersion: descheduler/v1alpha2
    kind: DeschedulerPolicy
    profiles:
    - name: ProfileName
      pluginConfig:
      - name: DomainFilter
        args:
          namespaces:
            included:
            - namespace-1
            - namespace-2
            excluded:
            - namespace-A
            - namespace-B
          labelSelector: ...
      - name: DefaultEvictor
        args:
          evictSystemCriticalPods: true # default false
          evictFailedBarePods: true # default false
          evictLocalStoragePods: true # default false
          nodeFit: true # default false
      - name: PodsHavingTooManyRestarts
        args:
          podRestartThreshold: 100
          includingInitContainers: true
      - name: LowNodeUtilization
        args:
          lowThreshold:
            cpu : 20
            memory: 20
            pods: 20
          highThreshold:
            cpu : 50
            memory: 50
            pods: 50
      - name: TopologySpreadConstraint
        args:
          includeSoftConstraints: true
      plugins:
        filter:
          # default filters: DomainFilter
          disabled:
          enabled:
        sort:
          # default sorters: Priority
          disabled:
            Priority
          enabled:
            Utilization
        deschedule:
          # plugins descheduling pods without checking other pods
          enabled:
          - PodsHavingTooManyRestarts
          - InterPodAntiAffinity
        rebalance:
          # plugins descheduling pods while balancing distribution
          enabled:
          - Duplicates
          - LowNodeUtilization
          - TopologySpreadConstraint
        evict:
          # default evict plugins: DefaultEvictor
          disabled:
            DefaultEvictor
          enabled:
            CustomEvictor

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 6, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 6, 2022
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 7, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 7, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 7, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from ingvagabund after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2022
@k8s-ci-robot
Copy link
Contributor

@ingvagabund: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 7, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 4, 2022
@ingvagabund
Copy link
Contributor Author

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 10, 2022
@k8s-ci-robot
Copy link
Contributor

@ingvagabund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-descheduler-verify-master d7745ff link true /test pull-descheduler-verify-master
pull-descheduler-unit-test-master-master d7745ff link true /test pull-descheduler-unit-test-master-master
pull-descheduler-test-e2e-k8s-master-1-22 d7745ff link true /test pull-descheduler-test-e2e-k8s-master-1-22
pull-descheduler-test-e2e-k8s-master-1-21 d7745ff link true /test pull-descheduler-test-e2e-k8s-master-1-21
pull-descheduler-test-e2e-k8s-master-1-23 d7745ff link true /test pull-descheduler-test-e2e-k8s-master-1-23
pull-descheduler-test-e2e-k8s-master-1-24 d7745ff link true /test pull-descheduler-test-e2e-k8s-master-1-24
pull-descheduler-test-e2e-k8s-master-1-25 d7745ff link true /test pull-descheduler-test-e2e-k8s-master-1-25
pull-descheduler-test-e2e-k8s-master-1-26 d7745ff link true /test pull-descheduler-test-e2e-k8s-master-1-26

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 12, 2023
@ingvagabund
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 13, 2023
@knelasevero
Copy link
Contributor

I am closing this one 😅 I think everyone working on the framework had this saved somewhere and no need to keep this POC open :)

/close

@k8s-ci-robot
Copy link
Contributor

@knelasevero: Closed this PR.

In response to this:

I am closing this one 😅 I think everyone working on the framework had this saved somewhere and no need to keep this POC open :)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund deleted the descheduling-framework branch April 4, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants