-
Notifications
You must be signed in to change notification settings - Fork 9
Generate Kubebuilder project for ExecutionHook CRDs and controller #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: prydonius The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Awesome! Now that @prydonius has submitted this PR, I'll close my POC PR #2. |
| PodSelection PodSelection `json:"podSelection" protobuf:"bytes,1,opt,name=podSelection"` | ||
|
|
||
| // Name of the HookAction. This is required. | ||
| ActionName string `json:"actionName" protobuf:"bytes,2,opt,name=actionName"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this an ObjectReference to the the HookAction?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not an ObjectReference because we want to fix the namespace and kind here, but @xing-yang might have a better idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The application snapshot controller is supposed to create this ExecutionHook object dynamically and copy HookActionName to this spec.
|
@prydonius and I spoke offline and I'll be taking this PR forward. |
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I am also ok w/ getting this merged and working on top of that, preserving attribution. |
|
Closing this in favor of #4 |
|
/close |
|
@ashish-amarnath: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR generates a new Kubebuilder v2 project for the ExecutionHook CRDs and controller.
The HookAction API needs to be added and the controller logic needs to be implemented as per the KEP (https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190120-execution-hook-design.md#proposal).
Signed-off-by: Adnan Abdulhussein aadnan@vmware.com
cc @xing-yang @skriss @nrb @carlisia @ashish-amarnath