Skip to content

Conversation

@prydonius
Copy link

This PR generates a new Kubebuilder v2 project for the ExecutionHook CRDs and controller.

  • adds the ExecutionHook API
  • scaffolds out a controller for the ExecutionHook

The HookAction API needs to be added and the controller logic needs to be implemented as per the KEP (https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190120-execution-hook-design.md#proposal).

Signed-off-by: Adnan Abdulhussein aadnan@vmware.com

cc @xing-yang @skriss @nrb @carlisia @ashish-amarnath

Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prydonius
To complete the pull request process, please assign liyinan926
You can assign the PR to them by writing /assign @liyinan926 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 13, 2019
@xing-yang
Copy link

Awesome! Now that @prydonius has submitted this PR, I'll close my POC PR #2.

PodSelection PodSelection `json:"podSelection" protobuf:"bytes,1,opt,name=podSelection"`

// Name of the HookAction. This is required.
ActionName string `json:"actionName" protobuf:"bytes,2,opt,name=actionName"`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this an ObjectReference to the the HookAction?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not an ObjectReference because we want to fix the namespace and kind here, but @xing-yang might have a better idea.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The application snapshot controller is supposed to create this ExecutionHook object dynamically and copy HookActionName to this spec.

@ashish-amarnath
Copy link

@prydonius and I spoke offline and I'll be taking this PR forward.
Thanks for the clean hand-off, @prydonius!

@k8s-ci-robot k8s-ci-robot removed the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 26, 2019
@k8s-ci-robot
Copy link

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 26, 2019
@ashish-amarnath
Copy link

ashish-amarnath commented Dec 26, 2019

I am also ok w/ getting this merged and working on top of that, preserving attribution.

@ashish-amarnath
Copy link

Closing this in favor of #4

@ashish-amarnath
Copy link

/close

@k8s-ci-robot
Copy link

@ashish-amarnath: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants