From 62f4fa51a8e4b5edff25048578cb1eced966301b Mon Sep 17 00:00:00 2001 From: Michael Nikitochkin Date: Tue, 12 May 2020 13:03:34 +0200 Subject: [PATCH] Decrease log level for AWS provider when no changes required There are many messages, that do not provide usefull information: ``` time="2020-05-12T10:55:09Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones" time="2020-05-12T10:56:10Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones" time="2020-05-12T10:57:10Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones" time="2020-05-12T10:58:10Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones" time="2020-05-12T10:59:09Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones" time="2020-05-12T11:00:10Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones" time="2020-05-12T11:01:09Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones" ``` It would help to remove this noise to DEBUG level. --- provider/aws/aws.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/provider/aws/aws.go b/provider/aws/aws.go index 91961c9e1f..3aa97647c5 100644 --- a/provider/aws/aws.go +++ b/provider/aws/aws.go @@ -400,14 +400,14 @@ func (p *AWSProvider) ApplyChanges(ctx context.Context, changes *plan.Changes) e func (p *AWSProvider) submitChanges(ctx context.Context, changes []*route53.Change, zones map[string]*route53.HostedZone) error { // return early if there is nothing to change if len(changes) == 0 { - log.Info("All records are already up to date") + log.Debug("All records are already up to date") return nil } // separate into per-zone change sets to be passed to the API. changesByZone := changesByZone(zones, changes) if len(changesByZone) == 0 { - log.Info("All records are already up to date, there are no changes for the matching hosted zones") + log.Debug("All records are already up to date, there are no changes for the matching hosted zones") } var failedZones []string