-
Notifications
You must be signed in to change notification settings - Fork 168
Fix invalid maintenance exclusion command #2204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid maintenance exclusion command #2204
Conversation
| } | ||
|
|
||
| // To avoid unexpected GKE maintenance, create a 4-hour maintenance exclusion window. | ||
| startExclusionTime := time.Now().UTC() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe do a manual test run in dev project to be sure about the correctness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local run of test/run-k8s-integration-local.sh confirms that the command is correct.
I1016 18:02:23.815274 575953 utils.go:17] cmd args=[gcloud container clusters update pdcsi7cb6 --zone us-central1-b --quiet --add-maintenance-exclusion-name no-upgrades-during-test --add-maintenance-exclusion-start 2025-10-16T18:02:23Z --add-maintenance-exclusion-end 2025-10-16T20:02:23Z --add-maintenance-exclusion-scope no_upgrades]
Updating pdcsi7cb6...done.
Updated [https://container.googleapis.com/v1/projects/hanchiz-gke-dev/zones/us-central1-b/clusters/pdcsi7cb6].
|
@tonyzhc: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sunnylovestiramisu, tonyzhc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
This is a follow up to #2203. The gcloud command was incorrect.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: