Skip to content

Add qbarrand to reviewers and approvers #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2022
Merged

Add qbarrand to reviewers and approvers #7

merged 1 commit into from
Aug 19, 2022

Conversation

@qbarrand
Copy link
Contributor

@qbarrand qbarrand commented Aug 3, 2022 •
edited
Loading

Add contributors of https://github.com/qbarrand/oot-operator.
Only add @qbarrand for now as other contributors are not members of the kubernetes-sigs org yet.
Add empty CI scripts to pass the mandatory CI.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 3, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 3, 2022

Welcome @qbarrand!

It looks like this is your first PR to kubernetes-sigs/kernel-module-management 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kernel-module-management has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Aug 3, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Aug 17, 2022
@qbarrand qbarrand changed the title Add existing KMMO contributors Add qbarrand to reviewers and approvers Aug 17, 2022
@qbarrand
Copy link
Contributor Author

qbarrand commented Aug 17, 2022

/cc @mrunalp

@k8s-ci-robot k8s-ci-robot requested a review from mrunalp August 17, 2022 23:14
qbarrand referenced this pull request in qbarrand/kernel-module-management Aug 18, 2022
@qbarrand
Add a node reconciler (#7)
e02aef7 
Adds a NodeReconciler that reconciles Modules that apply to modified Nodes.
Get rid of KernelDaemonSetsMap in the Module API. Instead, Module maintains its ownership of the DaemonSets through the oot.node.kubernetes.io/module.name label.
Add a new e2e workflow with two nodes that involves labeling and unlabeling the second node to verify that the module gets loaded and unloaded as expected.
qbarrand referenced this pull request in qbarrand/kernel-module-management Aug 18, 2022
@qbarrand
Download golangci-lint instead of installing it in a vendored environ…
789273c 
…ment. (#7)

Among the consequences of vendoring dependencies is the fact that we cannot go install any package from the internet.
We have to either:
- list the code of the package as a dependency and vendor it, even though the operator does not use it, or;
- install the binary we need through other means.

This commit installs golangci-lint by downloading it from the GitHub release.
qbarrand referenced this pull request in qbarrand/kernel-module-management Aug 18, 2022
@qbarrand
Revert "Download golangci-lint instead of installing it in a vendored…
205d1cb 
… environment. (#7)"

This reverts commit 789273c.
golangci-lint will be reliably installed in the CI environment.
We will use the GOLANGCI_LINT environment variable to inject the path to
the binary when running that target.
mrunalp
mrunalp approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit f01a8a3 into kubernetes-sigs:main Aug 19, 2022
@qbarrand qbarrand deleted the patch-1 branch August 19, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

@zvonkok zvonkok Awaiting requested review from zvonkok

1 more reviewer

@mrunalp mrunalp mrunalp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mrunalp mrunalp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qbarrand @k8s-ci-robot @mrunalp