Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure nodes to use a proxy server #270

Closed
pablochacin opened this issue Feb 5, 2019 · 4 comments

Comments

Projects
4 participants
@pablochacin
Copy link
Contributor

commented Feb 5, 2019

In order to solve #136 the HTTP_PROXY and HTTPS_PROXY environment variables should be passed from the host machine to the node container as suggested here.

@neolit123

This comment has been minimized.

Copy link
Contributor

commented Feb 5, 2019

/help
(unless @BenTheElder can take this one?)
/kind feature
/priority important-soon

@pablochacin

This comment has been minimized.

Copy link
Contributor Author

commented Feb 5, 2019

/assign
/remove-help

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

I think initially we can just pass through the values of this from the host to each container at container create time.

Eventually I think I'd like to refactor that out into the context and make it possible to override (for the library case), but I'll do that as part of a larger cleanup of create options I've been hacking on that will land later...

@BenTheElder BenTheElder added this to To do in 1.0 via automation Feb 6, 2019

@BenTheElder BenTheElder added this to the 1.0 milestone Feb 6, 2019

@pablochacin

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2019

Agree on both ideas.

I was also thinking that eventually the environment could also be part of the config file, but I cannot think about specific use case that justifies it.

1.0 automation moved this from To do to Done Feb 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.