Fix nerdctl create multi-node cluster fail by do not create container concurrently #3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
yankay
changed the title
yankay
changed the title
yankay
changed the title
yankay
changed the title
This seems an important and missing feature, can we track this in the nerdctl project add a TODO in the code to reference it? |
aojea
reviewed
Apr 3, 2024
|
ping @yankay can you please add the comment so we can merge? |
Add todo nerdctl handles concurrency better Co-authored-by: Antonio Ojea <antonio.ojea.garcia@gmail.com> Signed-off-by: Kay Yan <kay.yan@daocloud.io>
yankay
force-pushed
the
fix-concurrent-crate-node
branch
from
6401fe9
to
724ea1a
Compare
|
/lgtm Thanks |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #3533
The issue is caused by creating a concurrent container with the network.
Because there is no lock for the container creation, there is some conflict with the CNI creation.
And there are no test cases of nerdctl for creating containers concurrently.