-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nerdctl create multi-node cluster fail by do not create container concurrently #3567
Fix nerdctl create multi-node cluster fail by do not create container concurrently #3567
Conversation
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
This seems an important and missing feature, can we track this in the nerdctl project add a TODO in the code to reference it? |
ping @yankay can you please add the comment so we can merge? |
Add todo nerdctl handles concurrency better Co-authored-by: Antonio Ojea <antonio.ojea.garcia@gmail.com> Signed-off-by: Kay Yan <kay.yan@daocloud.io>
6401fe9
to
724ea1a
Compare
/lgtm Thanks |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix: #3533
The issue is caused by creating a concurrent container with the network.
Because there is no lock for the container creation, there is some conflict with the CNI creation.
And there are no test cases of nerdctl for creating containers concurrently.