Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid intermediate file in Node.WriteFile #433

Merged
merged 1 commit into from Apr 3, 2019

Conversation

Projects
None yet
3 participants
@BenTheElder
Copy link
Member

commented Apr 3, 2019

Finally implemented #322 (comment)

This should help avoid #431, and it should be more efficient to boot!

@k8s-ci-robot k8s-ci-robot requested review from amwat and krzyzacy Apr 3, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amwat
Copy link
Contributor

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 3, 2019

@k8s-ci-robot k8s-ci-robot merged commit e05a33e into kubernetes-sigs:master Apr 3, 2019

12 of 14 checks passed

Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 3 redirect rules processed
Details
cla/linuxfoundation BenTheElder authorized
Details
deploy/netlify Deploy preview ready!
Details
pull-kind-build Job succeeded.
Details
pull-kind-conformance-parallel Job succeeded.
Details
pull-kind-conformance-parallel-1-11 Job succeeded.
Details
pull-kind-conformance-parallel-1-12 Job succeeded.
Details
pull-kind-conformance-parallel-1-13 Job succeeded.
Details
pull-kind-verify Job succeeded.
Details
pull-kind-verify-deps Skipped.
tide In merge pool.
Details

@BenTheElder BenTheElder deleted the BenTheElder:less-temp branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.