Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch update-generated.sh #535

Merged

Conversation

Projects
None yet
3 participants
@BenTheElder
Copy link
Member

commented May 15, 2019

  • tidy before vendor to minimize
  • quote variables properly
patch update-generated.sh
- tidy before vendor to minimize
- quote variables properly
@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented May 15, 2019

this is low priority but related to #528

@amwat

amwat approved these changes May 15, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amwat, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 267e752 into kubernetes-sigs:master May 15, 2019

11 of 13 checks passed

Header rules No header rules processed
Details
Pages changed 15 new files uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 3 redirect rules processed
Details
cla/linuxfoundation BenTheElder authorized
Details
deploy/netlify Deploy preview ready!
Details
pull-kind-build Job succeeded.
Details
pull-kind-conformance-parallel Job succeeded.
Details
pull-kind-conformance-parallel-1-12 Job succeeded.
Details
pull-kind-conformance-parallel-1-13 Job succeeded.
Details
pull-kind-conformance-parallel-1-14 Job succeeded.
Details
pull-kind-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.