Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support udp protocol in port forwarding #661

Merged
merged 1 commit into from Jul 12, 2019

Conversation

@posox
Copy link
Contributor

commented Jun 26, 2019

Closes issue: #660

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2019

Welcome @posox!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2019

Hi @posox. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tao12345666333

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

/ok-to-test

@tao12345666333
Copy link
Member

left a comment

Thanks.

/lgtm

@posox

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

@tao12345666333 @BenTheElder @amwat please review / merge

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Sorry I was out for the end of last week (US holiday) and apparently my previous review comments never submitted :(

Show resolved Hide resolved pkg/cluster/config/validate.go Outdated
Show resolved Hide resolved pkg/container/cri/types.go Outdated
Show resolved Hide resolved pkg/container/docker/critoflags.go Outdated

@posox posox force-pushed the posox:pf-protocol branch from 78c0658 to 13cc613 Jul 10, 2019

@k8s-ci-robot k8s-ci-robot added size/M and removed lgtm size/S labels Jul 10, 2019

@posox posox force-pushed the posox:pf-protocol branch 2 times, most recently from dc9a6c0 to a74c578 Jul 10, 2019

@BenTheElder
Copy link
Member

left a comment

thank you!

case cri.PortMappingProtocolSCTP:
protocol = "SCTP"
default:
protocol = "TCP"

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Jul 12, 2019

Member

imo this case should not happen and should require defaulted input instead, but we can change that in a follow up.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, posox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9205bac into kubernetes-sigs:master Jul 12, 2019

11 of 13 checks passed

Header rules No header rules processed
Details
Pages changed 1 new file uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 1 redirect rule processed
Details
cla/linuxfoundation posox authorized
Details
deploy/netlify Deploy preview ready!
Details
pull-kind-build Job succeeded.
Details
pull-kind-conformance-parallel Job succeeded.
Details
pull-kind-conformance-parallel-1-12 Job succeeded.
Details
pull-kind-conformance-parallel-1-13 Job succeeded.
Details
pull-kind-conformance-parallel-1-14 Job succeeded.
Details
pull-kind-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.