Add dual stack support by aojea · Pull Request #692 · kubernetes-sigs/kind

aojea · 2019-07-07T09:00:58Z

Add dual stack support to KIND, it also needs to add dual-stack support to KINDNET
Depends on:

New dependency for kindnet so we don't need annotations on the nodes:

KEP-1664: Better Support for Dual-Stack Node Addresses kubernetes/enhancements#1665

aojea · 2019-07-07T09:02:25Z

cc: @vllry @khenidak @Arvinderpal @aramase

Arvinderpal · 2019-07-09T16:07:51Z

@aojea how are you handling DNS/NAT64 in kind?

aojea · 2019-07-09T16:31:46Z

@aojea how are you handling DNS/NAT64 in kind?

not handling it, should we? conformance tests are passing without it, just modified CoreDNS to work without contacting upstream servers

Arvinderpal · 2019-07-09T17:25:29Z

@aojea how are you handling DNS/NAT64 in kind?

not handling it, should we? conformance tests are passing without it, just modified CoreDNS to work without contacting upstream servers

Ok, but I suspect e2e networking tests like the following that test external connectivity from pods won't pass. In that case, we'll either need to use GUA addresses or some sort of NATing with ULA addresses.

aojea · 2019-07-09T18:56:47Z

Full e2e working is the next milestone, we were able to have conformance working yesterday ... One step at s time 😅

aojea · 2020-10-30T10:35:25Z

/test pull-kind-conformance-parallel-dual-stack-ipv4-ipv6

aojea · 2020-10-30T12:36:01Z

/test pull-kind-conformance-parallel-dual-stack-ipv4-ipv6

aojea · 2020-10-30T15:26:27Z

/retest

aojea · 2020-10-30T15:51:01Z

/test all
wasn't using the last kindnet image

aojea · 2020-12-16T12:12:13Z

/test pull-kind-conformance-parallel-dual-stack-ipv4-ipv6

aojea · 2021-01-21T09:53:07Z

/test pull-kind-conformance-parallel-dual-stack-ipv4-ipv6

k8s-ci-robot · 2021-02-06T00:01:24Z

@aojea: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aojea · 2021-03-11T09:46:09Z

@BenTheElder we should revisit this now the 1.21 will have dualstack enabled by default

BenTheElder · 2021-03-26T06:58:27Z

generally lgtm. left comments.
in particular need to update the image, and I'm still dubious on the constant values.
we can iterate on the dependencies angle. I think we should cease importing k8s.io/* for trivial things, but we can handle that seperately.

Kindnet supports dual-stack

Enable ipv6 on nodes if dual-stack

Fix dual docs

aojea · 2021-03-26T10:40:50Z

/test pull-kind-conformance-parallel-dual-stack-ipv4-ipv6

generally lgtm. left comments.
in particular need to update the image, and I'm still dubious on the constant values.
we can iterate on the dependencies angle. I think we should cease importing k8s.io/* for trivial things, but we can handle that seperately.

modified constants and removed all the dependencies on k8s.io/utils

aojea · 2021-03-26T10:49:17Z

we need this for the dualstack CI job
kubernetes/test-infra#21537

once it is in kind I need to remember to change all the kubernetes jobs

k8s-ci-robot · 2021-03-26T11:17:56Z

@aojea: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kind-conformance-parallel	`863cfc0`	link	`/test pull-kind-conformance-parallel`
pull-kind-conformance-parallel-1-14	`1df6ecb`	link	`/test pull-kind-conformance-parallel-1-14`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

BenTheElder · 2021-03-27T06:04:18Z

Antonio and I discussed this a bit and looked around quite a bit, and also discussed with the azure folks (since AKS supports this though without any high level config for it).

... There really isn't any standard way to refer to this. Kubernetes has a bunch of distinct concepts with different names surrounding dualstack and the broader networking community seems to use a variety of formats for referring to this.

https://kubernetes.io/docs/concepts/services-networking/dual-stack/

dual seems fine enough. I didn't intend for this to be a major sticking point, just a chance to find the least surprising / most obvious value for users before shipping the API, but that doesn't really seem to exist.

BenTheElder · 2021-03-27T06:17:35Z

/test pull-kind-conformance-parallel-dual-stack-ipv4-ipv6

BenTheElder · 2021-03-27T06:48:02Z

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kind/692/pull-kind-conformance-parallel-dual-stack-ipv4-ipv6/1375693467413385216

🎉

BenTheElder · 2021-03-27T06:49:40Z

/lgtm
/approve
remaining nits can be addressed in follow up. past time to ship this.

for anyone following along, this has been helped along by a number of other PRs like #2043

k8s-ci-robot · 2021-03-27T06:49:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [BenTheElder,aojea]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

BenTheElder · 2021-03-27T06:53:19Z

/hold cancel

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 7, 2019

k8s-ci-robot requested review from krzyzacy and munnerz July 7, 2019 09:01

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 7, 2019

Arvinderpal reviewed Jul 9, 2019

View reviewed changes

Comment thread pkg/cluster/config/default.go Outdated

Comment thread pkg/cluster/config/v1alpha3/default.go Outdated

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2019

aojea force-pushed the dualstack branch from e24fa4d to 1cd41b3 Compare August 19, 2019 16:06

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2019

aojea force-pushed the dualstack branch from 1cd41b3 to 5ccfc51 Compare August 19, 2019 16:48

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 19, 2019

aojea force-pushed the dualstack branch 4 times, most recently from 3205861 to 0722b04 Compare August 25, 2019 16:29

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 25, 2019

aojea force-pushed the dualstack branch 2 times, most recently from 589ed64 to b5ca840 Compare August 26, 2019 12:11

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2019

aojea force-pushed the dualstack branch 3 times, most recently from 80fc05a to c72e79e Compare August 29, 2019 16:05

This was referenced Jan 22, 2021

v1alpha5 API design #2023

Open

[meta]: v0.11.0 priority tracking #2024

Closed

aojea commented Mar 11, 2021

View reviewed changes

Comment thread pkg/internal/apis/config/validate.go

BenTheElder reviewed Mar 17, 2021

View reviewed changes

Comment thread go.mod Outdated

BenTheElder reviewed Mar 26, 2021

View reviewed changes

Comment thread pkg/build/nodeimage/const_cni.go Outdated

BenTheElder reviewed Mar 26, 2021

View reviewed changes

Comment thread pkg/internal/apis/config/types.go Outdated

BenTheElder and others added 4 commits March 26, 2021 11:10

Kindnetd with dual-stack support

3dbeb89

Kindnet supports dual-stack

Add dual stack support: APIs

5657682

Enable ipv6 on nodes if dual-stack

Add dual stack support: Docs

ec617af

Fix dual docs

use kindnetd dualstack

04bdfc7

BenTheElder reviewed Mar 27, 2021

View reviewed changes

Comment thread site/content/docs/user/quick-start.md

BenTheElder mentioned this pull request Mar 27, 2021

DualStack UX #1275

Closed

Conversation

aojea commented Jul 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aojea commented Jul 7, 2019

Uh oh!

Uh oh!

Uh oh!

Arvinderpal commented Jul 9, 2019

Uh oh!

aojea commented Jul 9, 2019

Uh oh!

Arvinderpal commented Jul 9, 2019

Uh oh!

aojea commented Jul 9, 2019

Uh oh!

aojea commented Oct 30, 2020

Uh oh!

aojea commented Oct 30, 2020

Uh oh!

aojea commented Oct 30, 2020

Uh oh!

aojea commented Oct 30, 2020

Uh oh!

aojea commented Dec 16, 2020

Uh oh!

aojea commented Jan 21, 2021

Uh oh!

k8s-ci-robot commented Feb 6, 2021

Uh oh!

Uh oh!

aojea commented Mar 11, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BenTheElder commented Mar 26, 2021

Uh oh!

aojea commented Mar 26, 2021

Uh oh!

aojea commented Mar 26, 2021

Uh oh!

k8s-ci-robot commented Mar 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BenTheElder commented Mar 27, 2021

Uh oh!

Uh oh!

BenTheElder commented Mar 27, 2021

Uh oh!

BenTheElder commented Mar 27, 2021

Uh oh!

BenTheElder commented Mar 27, 2021

Uh oh!

k8s-ci-robot commented Mar 27, 2021

Uh oh!

BenTheElder commented Mar 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

aojea commented Jul 7, 2019 •

edited

Loading

k8s-ci-robot commented Mar 26, 2021 •

edited

Loading