Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go to 1.12.8 #768

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@BenTheElder
Copy link
Member

commented Aug 13, 2019

the go CVEs should not affect kind I think, but we should keep up anyhow

@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

golang:1.12.8 image is not available yet.... 😬

@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

/retest

1 similar comment
@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

/retest

@amwat

amwat approved these changes Aug 13, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amwat, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

test flake:

[k8s.io] Probing container should have monotonically increasing restart count [NodeConformance] [Conformance] expand_less	11m22s
test/e2e/framework/framework.go:699
Aug 14 00:04:16.645: pod container-probe-6595/liveness-3a5293b3-bd87-4e40-bc10-257cc69cc27f - expected number of restarts: 5, found restarts: 4
test/e2e/common/container_probe.go:462

/retest

@k8s-ci-robot k8s-ci-robot merged commit bc6ea0d into kubernetes-sigs:master Aug 14, 2019

11 of 13 checks passed

Header rules No header rules processed
Details
Pages changed 17 new files uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 1 redirect rule processed
Details
cla/linuxfoundation BenTheElder authorized
Details
deploy/netlify Deploy preview ready!
Details
pull-kind-build Job succeeded.
Details
pull-kind-conformance-parallel Job succeeded.
Details
pull-kind-conformance-parallel-1-12 Job succeeded.
Details
pull-kind-conformance-parallel-1-13 Job succeeded.
Details
pull-kind-conformance-parallel-1-14 Job succeeded.
Details
pull-kind-verify Job succeeded.
Details
tide In merge pool.
Details

@BenTheElder BenTheElder deleted the BenTheElder:1128 branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.