Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate kindnetd sources in image directory #854

Merged

Conversation

@BenTheElder
Copy link
Member

commented Sep 11, 2019

cc @aojea
No functional changes, but better scoping.
We do not intend to mix code between this image / module and the rest of the repo.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from aojea and munnerz Sep 11, 2019

@BenTheElder BenTheElder force-pushed the BenTheElder:consolidate-kindnetd branch from 9b6a166 to 0f4d7ba Sep 12, 2019

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Sep 12, 2019

@BenTheElder BenTheElder force-pushed the BenTheElder:consolidate-kindnetd branch 2 times, most recently from 4e3c63a to c4b0138 Sep 12, 2019

@BenTheElder BenTheElder force-pushed the BenTheElder:consolidate-kindnetd branch from c4b0138 to e9a25bf Sep 12, 2019

@aojea

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 12, 2019

@k8s-ci-robot k8s-ci-robot merged commit 54471c2 into kubernetes-sigs:master Sep 12, 2019

11 of 14 checks passed

tide Not mergeable. Needs lgtm label.
Details
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 1 redirect rule processed
Details
cla/linuxfoundation BenTheElder authorized
Details
deploy/netlify Deploy preview ready!
Details
pull-kind-build Job succeeded.
Details
pull-kind-conformance-parallel Job succeeded.
Details
pull-kind-conformance-parallel-1-12 Job succeeded.
Details
pull-kind-conformance-parallel-1-13 Job succeeded.
Details
pull-kind-conformance-parallel-1-14 Job succeeded.
Details
pull-kind-conformance-parallel-1-15 Job succeeded.
Details
pull-kind-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.