Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add homepage fields. #113

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
3 participants
@jordanwilson230
Copy link
Contributor

commented Mar 13, 2019

Adds a homepage field to the exec-as and prompt plugin manifests.
The homepage README has been revised to provide clear instructions, specific for the Krew plugins.


Checklist for plugin developers:

  • Read the Plugin Naming Guide (for new plugins)
  • Verify the installation from URL or a local archive works (kubectl krew install --manifest=[...] --archive=[...])
jordan
@ahmetb

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

Is there a reason why you’re pointing to a branch and not the master?

@jordanwilson230

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

@ahmetb There are some plugins in master that aren't meant for krew, and some are named differently. I created the krew branch to address the naming constraints and to provide only a subset of plugins that I thought would be useful to bring to krew (i.e., there's no need to add the kubectl switch plugin in master because there are already packages in krew that do the same thing).

@jordanwilson230 jordanwilson230 referenced this pull request Mar 15, 2019

Closed

Add homepage for plugin manifests #92

31 of 31 tasks complete

@ahmetb ahmetb merged commit e9f8de8 into kubernetes-sigs:master Mar 15, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.