Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify license headers #126

Merged
merged 1 commit into from Apr 2, 2019

Conversation

Projects
None yet
3 participants
@ahmetb
Copy link
Contributor

commented Apr 1, 2019

The new copyright header is "# Copyright © 2019 The Kubernetes Authors" for
plugin manifests, although I'm not sure if manifest files are treated as code
in this case.

At any rate, I'm still figuring out how to actually test for presence and
correctness of the license headers as part of CI.

/assign @nikhita

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Apr 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nikhita

nikhita approved these changes Apr 1, 2019

Copy link
Member

left a comment

/lgtm
/hold
This isn't really needed, but we can merge if you want to :) Manifest files don't really need the license header.

At any rate, I'm still figuring out how to actually test for presence and
correctness of the license headers as part of CI.

You can use a script! Example - kubernetes-sigs/cluster-api-provider-digitalocean#111

@ahmetb

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

This isn't really needed, but we can merge if you want to :) Manifest files don't really need the license header.

I think I wanted to reach some consistency about having license headers vs not (krew.yaml and one more plugin had it). Based on your recommendation I will remove this.

This saves us from using a hack/ script, which I was hesitant to write one as I was hoping there's a prow presubmit we could use. :P

Unify copyright headers
This removes all copyright headers form manifests for consistency.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

@ahmetb ahmetb force-pushed the ahmetb:update-licenses branch from b92504c to 494ba0e Apr 1, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Apr 1, 2019

@ahmetb ahmetb changed the title Add/update license headers Unify license headers Apr 1, 2019

@k8s-ci-robot k8s-ci-robot added size/S lgtm and removed size/L labels Apr 1, 2019

@nikhita

nikhita approved these changes Apr 2, 2019

Copy link
Member

left a comment

/lgtm

@nikhita

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit d442a75 into kubernetes-sigs:master Apr 2, 2019

2 of 3 checks passed

tide Not mergeable. Should not have do-not-merge/hold label.
Details
cla/linuxfoundation ahmetb authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.